From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Eric Christopher <echristo@redhat.com>
Cc: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>,
binutils@sources.redhat.com
Subject: Re: [PATCH] MIPS gas: Fix macro expansions for .set noat
Date: Thu, 17 Feb 2005 20:50:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.61L.0502171500300.28978@blysk.ds.pg.gda.pl> (raw)
In-Reply-To: <1108624232.4149.13.camel@localhost.localdomain>
On Wed, 16 Feb 2005, Eric Christopher wrote:
> > 2005-02-16 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
> >
> > /gas/ChangeLog
> > * config/tc-mips.c (macro): Don't fail but warn on $at uses
> > after .set noat, it may only be sloppy coding. Don't try to
> > avoid $at use by sacrificing the target register before it is
> > stored, it won't work.
>
> Actually I disagree. If the user used .set noat and has sloppy coding we
> should fall over like we would for .set nomacro or such.
What exactly do you mean?
$ cat nomacro.S
.set noreorder
.set nomacro
la $2,foo($3)
$ gcc -c nomacro.S
nomacro.S: Assembler messages:
nomacro.S:3: Warning: Macro instruction expanded into multiple instructions
$ objdump -Sr nomacro.o
nomacro.o: file format elf32-tradbigmips
Disassembly of section .text:
00000000 <.text>:
0: 8f820000 lw v0,0(gp)
0: R_MIPS_GOT16 foo
4: 00000000 nop
8: 00431021 addu v0,v0,v1
c: 00000000 nop
It's always been like this and when I complained once, asking for making
it an error I was told a warning was The Right Way and it was not going to
be changed, sigh...
If the rules have changed now, then I am happy about it as I've never
seen any benefit from the current behavior. But then the update should be
consistent and make all "set noat" and ".set nomacro" violations trigger
the same action.
Maciej
next prev parent reply other threads:[~2005-02-17 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-16 23:51 Thiemo Seufer
2005-02-17 0:25 ` Maciej W. Rozycki
2005-02-17 1:31 ` Maciej W. Rozycki
2005-02-17 1:34 ` Thiemo Seufer
2005-02-17 2:02 ` Maciej W. Rozycki
2005-02-17 7:10 ` Thiemo Seufer
2005-02-17 13:53 ` Eric Christopher
2005-02-17 20:50 ` Maciej W. Rozycki [this message]
2005-02-17 21:33 ` Thiemo Seufer
2005-02-18 0:21 ` Maciej W. Rozycki
2005-02-21 2:57 ` Thiemo Seufer
2005-02-18 23:01 ` Eric Christopher
2005-02-21 8:21 ` Thiemo Seufer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61L.0502171500300.28978@blysk.ds.pg.gda.pl \
--to=macro@linux-mips.org \
--cc=binutils@sources.redhat.com \
--cc=echristo@redhat.com \
--cc=ica2_ts@csv.ica.uni-stuttgart.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).