From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] MIPS gas: Fix macro expansions for .set noat
Date: Thu, 17 Feb 2005 02:02:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.61L.0502161935180.3450@blysk.ds.pg.gda.pl> (raw)
In-Reply-To: <20050216192153.GH1757@rembrandt.csv.ica.uni-stuttgart.de>
On Wed, 16 Feb 2005, Thiemo Seufer wrote:
> > More comments about that change -- as I understand our policy wrt $at
> > being used with ".set noat" in effect is to go for it regardless and only
> > issue a warning (that can be converted to an error with --fatal-warnings).
> > Therefore we shouldn't use as_bad() in this case.
>
> IMHO it should be an error if the result can't work at all. I don't
> see a case where overwriting the base register before its use could
> be the programmers intention.
I do agree it's of questionable use and I proposed changing it a few
years ago, but I got a response as I expressed above. Then if it's to be
done, it should be done consistently for all cases -- replacing respective
as_warn() calls with as_bad() ones should be the right way.
Note that the Alpha port has always treated using $at with ".set noat" in
effect as an error.
> > Moreover, the situation
> > is actually already handled in general -- see the bottom exit point from
> > macro() -- so we should really only track down the failing execution path
> > within that function and check whether its epilogue correctly executes a
> > functional equivalent of this code:
> >
> > if (used_at)
> > break;
> > else
> > return;
>
> This causes "used $at in .set noat" warnings. That's a rather confusing
> message, given that no use of $at was specified in the source.
It's actually 'Macro used $at after ".set noat"' and I think it's
perfectly clear.
Maciej
next prev parent reply other threads:[~2005-02-16 19:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-16 23:51 Thiemo Seufer
2005-02-17 0:25 ` Maciej W. Rozycki
2005-02-17 1:31 ` Maciej W. Rozycki
2005-02-17 1:34 ` Thiemo Seufer
2005-02-17 2:02 ` Maciej W. Rozycki [this message]
2005-02-17 7:10 ` Thiemo Seufer
2005-02-17 13:53 ` Eric Christopher
2005-02-17 20:50 ` Maciej W. Rozycki
2005-02-17 21:33 ` Thiemo Seufer
2005-02-18 0:21 ` Maciej W. Rozycki
2005-02-21 2:57 ` Thiemo Seufer
2005-02-18 23:01 ` Eric Christopher
2005-02-21 8:21 ` Thiemo Seufer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61L.0502161935180.3450@blysk.ds.pg.gda.pl \
--to=macro@linux-mips.org \
--cc=binutils@sources.redhat.com \
--cc=ica2_ts@csv.ica.uni-stuttgart.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).