From: "Martin Liška" <mliska@suse.cz>
To: Nick Clifton <nickc@redhat.com>, binutils@sourceware.org
Cc: Fangrui Song <maskray@google.com>
Subject: Re: [PATCH 1/2] refactor usage of compressed_debug_section_type
Date: Tue, 11 Oct 2022 15:27:00 +0200 [thread overview]
Message-ID: <1dc24422-6c24-a749-09a9-c5161e6e18f4@suse.cz> (raw)
In-Reply-To: <67793b99-21a1-5e31-d354-d2e6fbce5978@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]
On 10/11/22 14:06, Nick Clifton wrote:
> Hi Martin,
>
>> PING^1
> Sorry!
>
>
>> On 10/3/22 09:50, Martin Liška wrote:
>>> bfd/ChangeLog:
>>>
>>> * bfd-in.h (bfd_hash_set_default_size): Add COMPRESS_UNKNOWN
>>> enum value.
>>> (struct compressed_type_tuple): New.
>>> * bfd-in2.h (bfd_hash_set_default_size): Regenerate.
>>> (struct compressed_type_tuple): Likewise.
>>> * libbfd.c (ARRAY_SIZE): New macro.
>>> (bfd_get_compression_algorithm): New function.
>>> (bfd_get_compression_algorithm_name): Likewise.
>>>
>>> gas/ChangeLog:
>>>
>>> * as.c: Do not special-case, use the new functions.
>>>
>>> ld/ChangeLog:
>>>
>>> * emultempl/elf.em: Do not special-case, use the new functions.
>>> * lexsup.c (elf_static_list_options): Likewise.
>
> Approved - please apply.
>
> Cheers
> Nick
>
>
Hello.
Thanks, I've installed the patches and noticed the following obvious fix is needed.
I'm going to install it.
Cheers,
Martin
[-- Attachment #2: 0001-fix-compressed_debug_section_names-definition-for-zl.patch --]
[-- Type: text/x-patch, Size: 903 bytes --]
From 735fab23d68d66678eaa19e5751c49091c3bd299 Mon Sep 17 00:00:00 2001
From: Martin Liska <mliska@suse.cz>
Date: Tue, 11 Oct 2022 15:25:06 +0200
Subject: [PATCH] fix compressed_debug_section_names definition for "zlib"
bfd/ChangeLog:
* libbfd.c: Set COMPRESS_DEBUG_GABI_ZLIB for "zlib" value.
---
bfd/libbfd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bfd/libbfd.c b/bfd/libbfd.c
index 14e7d8ef34f..3090e0ae64b 100644
--- a/bfd/libbfd.c
+++ b/bfd/libbfd.c
@@ -1249,7 +1249,7 @@ _bfd_generic_init_private_section_data (bfd *ibfd ATTRIBUTE_UNUSED,
static const struct compressed_type_tuple compressed_debug_section_names[] =
{
{ COMPRESS_DEBUG_NONE, "none" },
- { COMPRESS_DEBUG, "zlib" },
+ { COMPRESS_DEBUG_GABI_ZLIB, "zlib" },
{ COMPRESS_DEBUG_GNU_ZLIB, "zlib-gnu" },
{ COMPRESS_DEBUG_GABI_ZLIB, "zlib-gabi" },
{ COMPRESS_DEBUG_ZSTD, "zstd" },
--
2.37.3
next prev parent reply other threads:[~2022-10-11 13:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 4:08 [PATCH v3] binutils, gdb: support zstd compressed debug sections Fangrui Song
2022-09-23 14:32 ` Simon Marchi
2022-09-26 5:12 ` Alan Modra
2022-09-26 7:20 ` Fangrui Song
2022-09-26 13:30 ` Alan Modra
2022-09-26 14:08 ` Simon Marchi
2022-09-27 0:33 ` Alan Modra
2022-09-23 15:45 ` Nick Clifton
2022-09-23 15:58 ` Simon Marchi
2022-09-23 18:20 ` Fangrui Song
2022-09-23 18:57 ` Simon Marchi
2022-09-23 20:34 ` Fangrui Song
2022-09-24 5:43 ` Eli Zaretskii
2022-09-24 6:53 ` Enze Li
2022-09-24 7:13 ` Fangrui Song
2022-09-27 18:06 ` Tom Tromey
2022-09-27 18:08 ` Tom Tromey
2022-09-27 18:53 ` Fangrui Song
2022-09-29 11:43 ` Martin Liška
2022-09-29 20:17 ` Fangrui Song
2022-09-30 9:48 ` [PATCH][RFC] add --enable-zstd-compressed-debug-sections configure option Martin Liška
2022-09-30 11:25 ` Pedro Alves
2022-09-30 12:42 ` Martin Liška
2022-10-01 7:31 ` Fangrui Song
2022-10-03 7:49 ` Martin Liška
2022-10-03 7:50 ` [PATCH 1/2] refactor usage of compressed_debug_section_type Martin Liška
2022-10-11 7:14 ` Martin Liška
2022-10-11 12:06 ` Nick Clifton
2022-10-11 13:27 ` Martin Liška [this message]
2022-10-03 7:50 ` [PATCH 2/2] add --enable-default-compressed-debug-sections-algorithm configure option Martin Liška
2022-10-11 7:14 ` Martin Liška
2022-10-11 12:08 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dc24422-6c24-a749-09a9-c5161e6e18f4@suse.cz \
--to=mliska@suse.cz \
--cc=binutils@sourceware.org \
--cc=maskray@google.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).