public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Thiemo Seufer <ths@networkno.de>
To: Eric Christopher <echristo@apple.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] Better checking of ISA/ASE/ABI options for MIPS gas
Date: Tue, 23 May 2006 05:27:00 -0000	[thread overview]
Message-ID: <20060523000839.GB9061@networkno.de> (raw)
In-Reply-To: <A9F8D906-B293-44CF-A220-E4E1798F60F0@apple.com>

Eric Christopher wrote:
[snip]
> >>And why change the table to include default extensions for the cpu?
> >
> >To handle them the same way as the ISA. This is for ASEs which are
> >always implemented in that particular CPU.
> 
> You'll need to look through the code and make sure we aren't depending on
> the value not being zero somewhere then.

I changed the test for is_isa in mips_cpu_info_from_isa() to
(flags & MIPS_CPU_IS_ISA). mips_cpu_info_from_isa() is the only user.

> To be honest I'd just prefer another field for "default ASEs".

  a) This would bloat the table by another field to initialise.
  b) There is no generic ISA with an ASE, both uses are mutually
     exclusive.


Thiemo

  reply	other threads:[~2006-05-23  0:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-23  0:08 Thiemo Seufer
2006-05-23  4:06 ` Eric Christopher
2006-05-23  4:40   ` Thiemo Seufer
2006-05-23  5:01     ` Eric Christopher
2006-05-23  5:27       ` Thiemo Seufer [this message]
2006-05-23  5:51         ` Eric Christopher
2006-05-23 12:10 ` Richard Sandiford
2006-05-23 13:34   ` Thiemo Seufer
2006-05-23 14:14     ` Richard Sandiford
2006-05-23 15:39       ` Thiemo Seufer
2006-05-23 17:47 ` Thiemo Seufer
2006-05-23 21:01   ` Richard Sandiford
2006-05-23 23:37     ` Thiemo Seufer
2006-05-24  1:46       ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060523000839.GB9061@networkno.de \
    --to=ths@networkno.de \
    --cc=binutils@sourceware.org \
    --cc=echristo@apple.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).