From: Richard Sandiford <richard@codesourcery.com>
To: Thiemo Seufer <ths@networkno.de>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] Better checking of ISA/ASE/ABI options for MIPS gas
Date: Tue, 23 May 2006 21:01:00 -0000 [thread overview]
Message-ID: <877j4cc1ba.fsf@talisman.home> (raw)
In-Reply-To: <20060523130537.GE9061@networkno.de> (Thiemo Seufer's message of "Tue, 23 May 2006 14:05:37 +0100")
Thiemo Seufer <ths@networkno.de> writes:
> Updated to take all comments into account, and expanded to allow also
> for .set fp={23,64,default}.
Thanks for agreeing to do this. The new patch looks really good to
me FWIW. (There are a couple of minor documentation niggles below.)
> Richard, do you care about the gcc update (if/when the release cycle
> permits it)?
I'm not sure what you mean here, but I'd certainly like to see gcc's &
gas's option handling kept in sync, so the gcc equivalent of this patch
is certainly welcome from my POV. And I'd see a long-lasting divergence
between gas and gcc as a bug, so I'd be happy to use the discretion
given to target maintainers and have the patch go in during stage 3.
> +The @code{.set gp=32} and @code{.set fp=32} directives allow to change
> +the size of registers for parts of an object. The default value is
> +restored by @code{.set gp=default} and @code{.set fp=default}.
> +
"allow to" seems to be missing an object. "allow <something> to"
or "tell the assembler to" (as you used in later hunks). Or maybe:
The @code{.set gp=32} and @code{.set fp=32} directives allow the size
of registers to be changed for parts of an object. The default value is
restored by @code{.set gp=default} and @code{.set fp=default}.
> @item -mgp64
> -Assume that 64-bit general purpose registers are available. This is
> -provided in the interests of symmetry with -gp32.
> +@itemx -mfp64
> +Assume that 64-bit registers are available. This is provided in the
> +interests of symmetry with @samp{-mgp32} and @samp{-mfp32}.
> +
> +The @code{.set gp=64} and @code{.set fp=64} directives allow to change
> +the size of registers for parts of an object. The default value is
> +restored by @code{.set gp=default} and @code{.set fp=default}.
Same here.
> -The directive @samp{.set mips16} puts the assembler into MIPS 16 mode,
> -in which it will assemble instructions for the MIPS 16 processor. Use
> -@samp{.set nomips16} to return to normal 32 bit mode.
> +@cindex MIPS CPU override
> +@kindex @code{.set arch=@var{cpu}}
> +Even finer control provides the @code{.set arch=@var{cpu}} directive.
"provides" -> "is provided by". Or:
The @code{.set arch=@var{cpu}} directive provides even finer control.
which flows better into:
> +It changes the effective CPU target and allows to assemble instructions
> +specific to a particular CPU. All CPUs supported by the @samp{-march}
> +command line option are also selectable by this directive. The original
> +value is restored by @code{.set arch=default}.
Same "allows to" problem as above.
The other doc bits looked fine to me.
Richard
next prev parent reply other threads:[~2006-05-23 13:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-23 0:08 Thiemo Seufer
2006-05-23 4:06 ` Eric Christopher
2006-05-23 4:40 ` Thiemo Seufer
2006-05-23 5:01 ` Eric Christopher
2006-05-23 5:27 ` Thiemo Seufer
2006-05-23 5:51 ` Eric Christopher
2006-05-23 12:10 ` Richard Sandiford
2006-05-23 13:34 ` Thiemo Seufer
2006-05-23 14:14 ` Richard Sandiford
2006-05-23 15:39 ` Thiemo Seufer
2006-05-23 17:47 ` Thiemo Seufer
2006-05-23 21:01 ` Richard Sandiford [this message]
2006-05-23 23:37 ` Thiemo Seufer
2006-05-24 1:46 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877j4cc1ba.fsf@talisman.home \
--to=richard@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=ths@networkno.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).