From: "H. J. Lu" <hjl@lucon.org>
To: binutils@sources.redhat.com, joern.rennecke@superh.com,
aoliva@redhat.com, kkojima@rr.iij4u.or.jp
Subject: Re: Should sh-*-* enable 64bit targets?
Date: Thu, 25 May 2006 14:45:00 -0000 [thread overview]
Message-ID: <20060525055855.GA9396@lucon.org> (raw)
In-Reply-To: <20060525031757.GE25824@bubble.grove.modra.org>
On Thu, May 25, 2006 at 12:47:57PM +0930, Alan Modra wrote:
> On Wed, May 24, 2006 at 07:33:03PM -0700, H. J. Lu wrote:
> > On Thu, May 25, 2006 at 10:48:25AM +0930, Alan Modra wrote:
> > > On Wed, May 24, 2006 at 05:58:22PM -0700, H. J. Lu wrote:
> > > > sh-*-linux*)
> > > > targ_defvec=bfd_elf32_shblin_vec
> > > > targ_selvecs=bfd_elf32_shlin_vec
> > > > -#ifdef BFD64
> > > > - targ_selvecs="${targ_selvecs} bfd_elf32_sh64lin_vec bfd_elf32_sh64blin_vec bfd_elf64_sh64lin_vec bfd_elf64_sh64blin_vec"
> > > > -#endif
> > > > + targ64_selvecs="bfd_elf32_sh64lin_vec bfd_elf32_sh64blin_vec bfd_elf64_sh64lin_vec bfd_elf64_sh64blin_vec"
> > > > ;;
> > >
> > > You should have set want64=true here and in the other sh cases you
> > > changed to use targ64_selvecs.
> >
> > I am not sure what the original intention was. I assume they wanted
> > to enable 64bit targets if BFD was 64bit. That is what my change does
> > by setting targ64_selvecs.
>
> #ifdef in a shell script is just a comment. So the original config.bfd
> always included the 64-bit sh targets in target_selvecs. Your patch
> to use targ64_selvecs changes that behaviour. Please add want64=true.
I built the sh-linux cross binutils without my patch:
[hjl@gnu-13 binutils-import-cross]$ ./build-sh-linux/ld/ld-new -V
GNU ld version 2.17.50 20060524
Supported emulations:
shlelf_linux
shelf_linux
My patch doesn't change it. The question is what the original
intention was.
I don't think "#ifdef BFD64" is just a comment. targmatch.sed will put
them into targmatch.h:
#ifdef BFD64
...
#endif
H.J.
next prev parent reply other threads:[~2006-05-25 5:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-25 3:19 PATCH: ld/1485: --enable-targets=all doesn't work for 64bit target H. J. Lu
2006-05-25 3:48 ` Alan Modra
2006-05-25 4:20 ` H. J. Lu
2006-05-25 5:01 ` Alan Modra
2006-05-25 5:51 ` Should sh-*-* enable 64bit targets? H. J. Lu
2006-05-25 5:55 ` Alan Modra
2006-05-25 14:45 ` H. J. Lu [this message]
2006-05-25 14:56 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060525055855.GA9396@lucon.org \
--to=hjl@lucon.org \
--cc=aoliva@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=joern.rennecke@superh.com \
--cc=kkojima@rr.iij4u.or.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).