From: Alan Modra <amodra@bigpond.net.au>
To: "H. J. Lu" <hjl@lucon.org>
Cc: binutils@sources.redhat.com
Subject: Re: PATCH: ld/1485: --enable-targets=all doesn't work for 64bit target
Date: Thu, 25 May 2006 03:48:00 -0000 [thread overview]
Message-ID: <20060524235309.GB25824@bubble.grove.modra.org> (raw)
In-Reply-To: <20060524172325.GA4375@lucon.org>
On Wed, May 24, 2006 at 10:23:25AM -0700, H. J. Lu wrote:
> --- ld/configure.in.64 2006-04-14 14:44:46.000000000 -0700
> +++ ld/configure.in 2006-05-24 10:16:18.000000000 -0700
> @@ -169,6 +169,11 @@ do
> EMUL=$targ_emul
> fi
>
> + . ${srcdir}/../bfd/config.bfd
> + case "${targ_defvec}-${targ_selvecs}" in
> + *elf64*) want64=true;;
> + esac
> +
> for i in $targ_emul $targ_extra_emuls $targ_extra_libpath; do
> case " $all_emuls " in
> *" e${i}.o "*) ;;
Please don't add the case statement here. Instead, set want64 in
config.bfd on each target that has a 64-bit BFD, ie. everything inside
#ifdef BFD64. Patch preapproved with that change. I know there are
some targets that are 64-bit but don't have "elf64" support.
--
Alan Modra
IBM OzLabs - Linux Technology Centre
next prev parent reply other threads:[~2006-05-24 23:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-25 3:19 H. J. Lu
2006-05-25 3:48 ` Alan Modra [this message]
2006-05-25 4:20 ` H. J. Lu
2006-05-25 5:01 ` Alan Modra
2006-05-25 5:51 ` Should sh-*-* enable 64bit targets? H. J. Lu
2006-05-25 5:55 ` Alan Modra
2006-05-25 14:45 ` H. J. Lu
2006-05-25 14:56 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060524235309.GB25824@bubble.grove.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
--cc=hjl@lucon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).