public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@bigpond.net.au>
To: "H. J. Lu" <hjl@lucon.org>
Cc: binutils@sources.redhat.com, joern.rennecke@superh.com,
		aoliva@redhat.com, kkojima@rr.iij4u.or.jp
Subject: Re: Should sh-*-* enable 64bit targets?
Date: Thu, 25 May 2006 14:56:00 -0000	[thread overview]
Message-ID: <20060525080300.GG25824@bubble.grove.modra.org> (raw)
In-Reply-To: <20060525055855.GA9396@lucon.org>

On Wed, May 24, 2006 at 10:58:55PM -0700, H. J. Lu wrote:
> I built the sh-linux cross binutils without my patch:
> 
> [hjl@gnu-13 binutils-import-cross]$ ./build-sh-linux/ld/ld-new -V
> GNU ld version 2.17.50 20060524
>   Supported emulations:
>    shlelf_linux
>    shelf_linux
> 
> My patch doesn't change it.

Ridiculous.  You didn't even build a sh-linux cross on a host that tests
your change!

src/binutils-current/configure --prefix=/usr/local --disable-nls --build=i586-linux --host=i586-linux --target=sh-linux

.
.

../opcodes/.libs/libopcodes.a(sh64-dis.o): In function `sh64_get_contents_type_disasm':
/src/binutils-current/opcodes/sh64-dis.c:463: undefined reference to `sh64_get_contents_type'
/src/binutils-current/opcodes/sh64-dis.c:477: undefined reference to `sh64_get_contents_type'
collect2: ld returned 1 exit status
make[4]: *** [objdump] Error 1
make[4]: Leaving directory `/home/alan/build/gas/sh/binutils'

> The question is what the original intention was.

I don't care what the original intent of those SH #ifdef BFD64 tests
were.  They are quite useless.

> I don't think "#ifdef BFD64" is just a comment. targmatch.sed will put
> them into targmatch.h:

For the purpose of running config.bfd as a shell script, it is most
definitely just a comment.  targmatch.sed only picks out targ_defvec, so
in the case of the SH #ifdef BFD64, it is useless for targmatch.h too.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

      reply	other threads:[~2006-05-25  8:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-25  3:19 PATCH: ld/1485: --enable-targets=all doesn't work for 64bit target H. J. Lu
2006-05-25  3:48 ` Alan Modra
2006-05-25  4:20   ` H. J. Lu
2006-05-25  5:01     ` Alan Modra
2006-05-25  5:51       ` Should sh-*-* enable 64bit targets? H. J. Lu
2006-05-25  5:55         ` Alan Modra
2006-05-25 14:45           ` H. J. Lu
2006-05-25 14:56             ` Alan Modra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060525080300.GG25824@bubble.grove.modra.org \
    --to=amodra@bigpond.net.au \
    --cc=aoliva@redhat.com \
    --cc=binutils@sources.redhat.com \
    --cc=hjl@lucon.org \
    --cc=joern.rennecke@superh.com \
    --cc=kkojima@rr.iij4u.or.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).