Re: oss-fuzz: binutils: Fuzzing build failure

[Alan Modra <amodra@gmail.com>]

On Fri, Sep 18, 2020 at 09:14:42PM +0200, Philippe Antoine wrote:
> Latest clang introduced a new warning again.
> And it found a bug in binutils, preventing the oss-fuzz build

Thanks, I committed a variation on your patch, trimming off trailing
commas too.

	* rx-dis.c (flag_names): Add missing comma.
	(register_names, flag_names, double_register_names),
	(double_register_high_names, double_register_low_names),
	(double_control_register_names, double_condition_names): Remove
	trailing commas.

diff --git a/opcodes/rx-dis.c b/opcodes/rx-dis.c
index 29ba71c121..1e5591ca98 100644
--- a/opcodes/rx-dis.c
+++ b/opcodes/rx-dis.c
@@ -85,7 +85,7 @@ static char const * register_names[] =
   "psw", "pc", "usp", "fpsw", NULL, NULL, NULL, NULL,
   "bpsw", "bpc", "isp", "fintv", "intb", "extb", NULL, NULL,
   "a0", "a1", NULL, NULL, NULL, NULL, NULL, NULL,
-  NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+  NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL
 };
 
 static char const * condition_names[] =
@@ -99,36 +99,36 @@ static const char * flag_names[] =
 {
   "c", "z", "s", "o", "", "", "", "",
   "", "", "", "", "", "", "", "",
-  "i", "u", "", "", "", "", "", ""
-  "", "", "", "", "", "", "", "",
+  "i", "u", "", "", "", "", "", "",
+  "", "", "", "", "", "", "", ""
 };
 
 static const char * double_register_names[] =
 {
   "dr0", "dr1", "dr2", "dr3", "dr4", "dr5", "dr6", "dr7",
-  "dr8", "dr9", "dr10", "dr11", "dr12", "dr13", "dr14", "dr15",
+  "dr8", "dr9", "dr10", "dr11", "dr12", "dr13", "dr14", "dr15"
 };
 
 static const char * double_register_high_names[] =
 {
   "drh0", "drh1", "drh2", "drh3", "drh4", "drh5", "drh6", "drh7",
-  "drh8", "drh9", "drh10", "drh11", "drh12", "drh13", "drh14", "drh15",
+  "drh8", "drh9", "drh10", "drh11", "drh12", "drh13", "drh14", "drh15"
 };
 
 static const char * double_register_low_names[] =
 {
   "drl0", "drl1", "drl2", "drl3", "drl4", "drl5", "drl6", "drl7",
-  "drl8", "drl9", "drl10", "drl11", "drl12", "drl13", "drl14", "drl15",
+  "drl8", "drl9", "drl10", "drl11", "drl12", "drl13", "drl14", "drl15"
 };
 
 static const char * double_control_register_names[] =
 {
-  "dpsw", "dcmr", "decnt", "depc",
+  "dpsw", "dcmr", "decnt", "depc"
 };
 
 static const char * double_condition_names[] =
 {
-  "", "un", "eq", "", "lt", "", "le",
+  "", "un", "eq", "", "lt", "", "le"
 };
 
 static inline const char *


-- 
Alan Modra
Australia Development Lab, IBM