public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Philippe Antoine <p.antoine@catenacyber.fr>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: oss-fuzz: binutils: Fuzzing build failure
Date: Mon, 21 Sep 2020 13:53:05 +0200	[thread overview]
Message-ID: <B3DB65D1-71B4-4AC2-9CDB-2C0750A5A769@catenacyber.fr> (raw)
In-Reply-To: <20200921091631.GY5452@bubble.grove.modra.org>

[-- Attachment #1: Type: text/plain, Size: 2699 bytes --]

Thanks Alan

> Le 21 sept. 2020 à 11:16, Alan Modra <amodra@gmail.com> a écrit :
> 
> On Fri, Sep 18, 2020 at 09:14:42PM +0200, Philippe Antoine wrote:
>> Latest clang introduced a new warning again.
>> And it found a bug in binutils, preventing the oss-fuzz build
> 
> Thanks, I committed a variation on your patch, trimming off trailing
> commas too.
> 
> 	* rx-dis.c (flag_names): Add missing comma.
> 	(register_names, flag_names, double_register_names),
> 	(double_register_high_names, double_register_low_names),
> 	(double_control_register_names, double_condition_names): Remove
> 	trailing commas.
> 
> diff --git a/opcodes/rx-dis.c b/opcodes/rx-dis.c
> index 29ba71c121..1e5591ca98 100644
> --- a/opcodes/rx-dis.c
> +++ b/opcodes/rx-dis.c
> @@ -85,7 +85,7 @@ static char const * register_names[] =
>   "psw", "pc", "usp", "fpsw", NULL, NULL, NULL, NULL,
>   "bpsw", "bpc", "isp", "fintv", "intb", "extb", NULL, NULL,
>   "a0", "a1", NULL, NULL, NULL, NULL, NULL, NULL,
> -  NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> +  NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL
> };
> 
> static char const * condition_names[] =
> @@ -99,36 +99,36 @@ static const char * flag_names[] =
> {
>   "c", "z", "s", "o", "", "", "", "",
>   "", "", "", "", "", "", "", "",
> -  "i", "u", "", "", "", "", "", ""
> -  "", "", "", "", "", "", "", "",
> +  "i", "u", "", "", "", "", "", "",
> +  "", "", "", "", "", "", "", ""
> };
> 
> static const char * double_register_names[] =
> {
>   "dr0", "dr1", "dr2", "dr3", "dr4", "dr5", "dr6", "dr7",
> -  "dr8", "dr9", "dr10", "dr11", "dr12", "dr13", "dr14", "dr15",
> +  "dr8", "dr9", "dr10", "dr11", "dr12", "dr13", "dr14", "dr15"
> };
> 
> static const char * double_register_high_names[] =
> {
>   "drh0", "drh1", "drh2", "drh3", "drh4", "drh5", "drh6", "drh7",
> -  "drh8", "drh9", "drh10", "drh11", "drh12", "drh13", "drh14", "drh15",
> +  "drh8", "drh9", "drh10", "drh11", "drh12", "drh13", "drh14", "drh15"
> };
> 
> static const char * double_register_low_names[] =
> {
>   "drl0", "drl1", "drl2", "drl3", "drl4", "drl5", "drl6", "drl7",
> -  "drl8", "drl9", "drl10", "drl11", "drl12", "drl13", "drl14", "drl15",
> +  "drl8", "drl9", "drl10", "drl11", "drl12", "drl13", "drl14", "drl15"
> };
> 
> static const char * double_control_register_names[] =
> {
> -  "dpsw", "dcmr", "decnt", "depc",
> +  "dpsw", "dcmr", "decnt", "depc"
> };
> 
> static const char * double_condition_names[] =
> {
> -  "", "un", "eq", "", "lt", "", "le",
> +  "", "un", "eq", "", "lt", "", "le"
> };
> 
> static inline const char *
> 
> 
> -- 
> Alan Modra
> Australia Development Lab, IBM


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2740 bytes --]

      reply	other threads:[~2020-09-21 11:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0=1d79688ba06d41b624f807a991e6c9ee=59d48433e0764783d31f65a1dd0c2b85=oss-fuzz@monorail-prod.appspotmail.com>
     [not found] ` <0000000000001f161f0598158d92@google.com>
     [not found]   ` <F580BE4E-75A4-493D-A5C1-DEE6E68071F3@catenacyber.fr>
     [not found]     ` <411708c7-7c97-9a48-c072-1f1c1109c3c7@redhat.com>
     [not found]       ` <0FBB84B3-27CB-4884-8AB5-0216EA447A28@catenacyber.fr>
     [not found]         ` <ce754fc9-edcc-7ca0-9d76-ae16fece10f3@redhat.com>
     [not found]           ` <E183C216-573D-46D3-AA24-371315273B70@catenacyber.fr>
2020-09-21  9:16             ` Alan Modra
2020-09-21 11:53               ` Philippe Antoine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B3DB65D1-71B4-4AC2-9CDB-2C0750A5A769@catenacyber.fr \
    --to=p.antoine@catenacyber.fr \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).