public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Nick Clifton <nickc@redhat.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 2/3] Sync libiberty and include with GCC for get_DW_UT_name.
Date: Thu, 24 Sep 2020 23:12:49 +0200	[thread overview]
Message-ID: <20200924211249.GC5317@wildebeest.org> (raw)
In-Reply-To: <b60728d2-c29a-7bdc-bd10-7de6311ad5a0@redhat.com>

Hi Nick,

On Thu, Sep 24, 2020 at 11:26:42AM +0100, Nick Clifton wrote:
> > include/ChangeLog:
> > 
> > 	* dwarf2.def: Add DWARF5 Unit type header encoding macros
> > 	DW_UT_FIRST, DW_UT and DW_UT_END.
> > 	* dwarf2.h (enum dwarf_unit_type): Removed and define using
> > 	DW_UT_FIRST, DW_UT and DW_UT_END macros.
> > 	(get_DW_UT_name): New function declaration.
> > 
> > libiberty/ChangeLog:
> > 
> > 	* dwarfnames.c (get_DW_UT_name): Define using DW_UT_FIRST, DW_UT
> > 	and DW_UT_END.
>  
> Approved - please apply.  Note the convention with libiberty/ChangeLog 
> entries is to say "Sync with GCC" and then provide a copy of gcc's
> libiberty changelog entry.

Sorry, I cheated a bit and had submitted the GCC change at the same
time as the binutils one and had forgotten to add the Sync with GCC to
the commit message Changelog (it was actually in the ChangeLog file
entry). The patch has been accepted for GCC now. I have added the same
Sync with GCC to the commit message.

BTW. It would be nice if binutils adopted the same method as GCC and
only required the ChangeLog entries in the commit message and not
require an actual ChangeLog file entry.

Thanks,

Mark

  reply	other threads:[~2020-09-24 21:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23 14:51 [PATCH 1/3] binutils: Handle DWARF5 DW_FORM_ref_addr and DW_UT_partial Mark Wielaard
2020-09-23 14:51 ` [PATCH 2/3] Sync libiberty and include with GCC for get_DW_UT_name Mark Wielaard
2020-09-24 10:26   ` Nick Clifton
2020-09-24 21:12     ` Mark Wielaard [this message]
2020-09-25  2:23       ` Alan Modra
2020-09-25  9:38         ` Mark Wielaard
2020-09-23 14:51 ` [PATCH 3/3] readelf: Show Unit Type for DWARF5 Mark Wielaard
2020-09-24 10:27   ` Nick Clifton
2020-09-24 10:23 ` [PATCH 1/3] binutils: Handle DWARF5 DW_FORM_ref_addr and DW_UT_partial Nick Clifton
2020-09-24 20:55   ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200924211249.GC5317@wildebeest.org \
    --to=mark@klomp.org \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).