public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Fangrui Song <i@maskray.me>
To: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 0/4] gas: Add support for LLVM addrsig and addrsig_sym.
Date: Wed, 25 May 2022 00:19:24 -0700	[thread overview]
Message-ID: <20220525071924.ofjz32r53hdbgchk@gmail.com> (raw)
In-Reply-To: <20220525064252.58603-1-ishitatsuyuki@gmail.com>

On 2022-05-25, Tatsuyuki Ishi via Binutils wrote:
>This patch adds support for the relevant LLVM assembler directives,
>which is a prerequisite for GCC support of the feature.
>
>[1]: https://llvm.org/docs/Extensions.html#sht-llvm-addrsig-section-address-significance-table
>
>

I have to be fair, the design of SHT_LLVM_ADDRSIG has a major problem
that it does not work with objcopy and ld -r:
https://sourceware.org/bugzilla/show_bug.cgi?id=23817
That said, using relocations would greatly increase the size of the
section and the current uleb128 does a good job on decreasing the file
size...

If ld supports SHT_LLVM_ADDRSIG, it would probably make it easier
to assemble `clang -S` output with `as`. Currently, on many targets/Linux
distributions, `clang -S` defaults to -faddrsig which makes the output
not-assembable with `as`.

  parent reply	other threads:[~2022-05-25  7:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25  6:42 Tatsuyuki Ishi
2022-05-25  6:42 ` [PATCH 1/4] elf: Add definition for SHT_LLVM_ADDRSIG Tatsuyuki Ishi
2022-05-26 10:03   ` Jan Beulich
2022-05-26 10:13     ` Tatsuyuki Ishi
2022-05-26 10:19       ` Jan Beulich
2022-05-26 10:36         ` Tatsuyuki Ishi
2022-05-27 17:28           ` Peter Collingbourne
2022-05-25  6:42 ` [PATCH 2/4] gas: Add support for LLVM addrsig and addrsig_sym directives on ELF Tatsuyuki Ishi
2022-05-25  7:23   ` Alan Modra
2022-05-25  7:49   ` Jan Beulich
2022-05-25  7:58     ` Tatsuyuki Ishi
2022-05-25  8:07       ` Fangrui Song
2022-05-25  8:34       ` Jan Beulich
2022-05-25  8:41         ` Tatsuyuki Ishi
2022-05-25  6:42 ` [PATCH 3/4] bfd: Output SH_LINK to .symtab for SHT_LLVM_ADDRSIG Tatsuyuki Ishi
2022-05-25  7:46   ` Jan Beulich
2022-05-25  6:42 ` [PATCH 4/4] gas: Add basic test for addrsig Tatsuyuki Ishi
2022-05-25  7:30   ` Alan Modra
2022-05-25  7:19 ` Fangrui Song [this message]
2022-05-25  7:34   ` [PATCH 0/4] gas: Add support for LLVM addrsig and addrsig_sym Alan Modra
2022-05-25  7:59     ` Fangrui Song
2022-05-25  8:01     ` Tatsuyuki Ishi
2022-05-25  6:46 Tatsuyuki Ishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220525071924.ofjz32r53hdbgchk@gmail.com \
    --to=i@maskray.me \
    --cc=binutils@sourceware.org \
    --cc=ishitatsuyuki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).