From: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
To: Alan Modra <amodra@gmail.com>
Cc: Fangrui Song <i@maskray.me>, binutils@sourceware.org
Subject: Re: [PATCH 0/4] gas: Add support for LLVM addrsig and addrsig_sym.
Date: Wed, 25 May 2022 17:01:14 +0900 [thread overview]
Message-ID: <CANqewP08GxE1d2R1OmwVZz=sOvVUEibmSHKmPZ62UmH4PvxiLQ@mail.gmail.com> (raw)
In-Reply-To: <Yo3cGWMfe92mIU2n@squeak.grove.modra.org>
> So, discard the section on ld -r and objcopy if symbols change?
Actually, this is something I need to take care of. LLD currently uses sh_link=0
as a heuristic for such corrupted entries:
https://github.com/llvm/llvm-project/blob/09c2b7c35af8c4bad39f03e9f60df8bd07323028/lld/ELF/InputFiles.cpp#L540-L554
But if we add the sh_link marking into bfd (patch #3), then it will
silently break again, if I understand correctly.
Does discarding sound good to you?
next prev parent reply other threads:[~2022-05-25 8:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 6:42 Tatsuyuki Ishi
2022-05-25 6:42 ` [PATCH 1/4] elf: Add definition for SHT_LLVM_ADDRSIG Tatsuyuki Ishi
2022-05-26 10:03 ` Jan Beulich
2022-05-26 10:13 ` Tatsuyuki Ishi
2022-05-26 10:19 ` Jan Beulich
2022-05-26 10:36 ` Tatsuyuki Ishi
2022-05-27 17:28 ` Peter Collingbourne
2022-05-25 6:42 ` [PATCH 2/4] gas: Add support for LLVM addrsig and addrsig_sym directives on ELF Tatsuyuki Ishi
2022-05-25 7:23 ` Alan Modra
2022-05-25 7:49 ` Jan Beulich
2022-05-25 7:58 ` Tatsuyuki Ishi
2022-05-25 8:07 ` Fangrui Song
2022-05-25 8:34 ` Jan Beulich
2022-05-25 8:41 ` Tatsuyuki Ishi
2022-05-25 6:42 ` [PATCH 3/4] bfd: Output SH_LINK to .symtab for SHT_LLVM_ADDRSIG Tatsuyuki Ishi
2022-05-25 7:46 ` Jan Beulich
2022-05-25 6:42 ` [PATCH 4/4] gas: Add basic test for addrsig Tatsuyuki Ishi
2022-05-25 7:30 ` Alan Modra
2022-05-25 7:19 ` [PATCH 0/4] gas: Add support for LLVM addrsig and addrsig_sym Fangrui Song
2022-05-25 7:34 ` Alan Modra
2022-05-25 7:59 ` Fangrui Song
2022-05-25 8:01 ` Tatsuyuki Ishi [this message]
2022-05-25 6:46 Tatsuyuki Ishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANqewP08GxE1d2R1OmwVZz=sOvVUEibmSHKmPZ62UmH4PvxiLQ@mail.gmail.com' \
--to=ishitatsuyuki@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=i@maskray.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).