public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 3/4] bfd: Output SH_LINK to .symtab for SHT_LLVM_ADDRSIG.
Date: Wed, 25 May 2022 09:46:11 +0200	[thread overview]
Message-ID: <ae33c4b9-043d-b946-f541-6611b19a269e@suse.com> (raw)
In-Reply-To: <20220525064252.58603-4-ishitatsuyuki@gmail.com>

On 25.05.2022 08:42, Tatsuyuki Ishi via Binutils wrote:
> --- a/bfd/elf.c
> +++ b/bfd/elf.c
> @@ -3988,6 +3988,7 @@ assign_section_numbers (bfd *abfd, struct bfd_link_info *link_info)
>  	  break;
>  
>  	case SHT_GROUP:
> +    case SHT_LLVM_ADDRSIG:
>  	  d->this_hdr.sh_link = elf_onesymtab (abfd);

Nit: You want to properly indent the line you're adding.

Jan


  reply	other threads:[~2022-05-25  7:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25  6:42 [PATCH 0/4] gas: Add support for LLVM addrsig and addrsig_sym Tatsuyuki Ishi
2022-05-25  6:42 ` [PATCH 1/4] elf: Add definition for SHT_LLVM_ADDRSIG Tatsuyuki Ishi
2022-05-26 10:03   ` Jan Beulich
2022-05-26 10:13     ` Tatsuyuki Ishi
2022-05-26 10:19       ` Jan Beulich
2022-05-26 10:36         ` Tatsuyuki Ishi
2022-05-27 17:28           ` Peter Collingbourne
2022-05-25  6:42 ` [PATCH 2/4] gas: Add support for LLVM addrsig and addrsig_sym directives on ELF Tatsuyuki Ishi
2022-05-25  7:23   ` Alan Modra
2022-05-25  7:49   ` Jan Beulich
2022-05-25  7:58     ` Tatsuyuki Ishi
2022-05-25  8:07       ` Fangrui Song
2022-05-25  8:34       ` Jan Beulich
2022-05-25  8:41         ` Tatsuyuki Ishi
2022-05-25  6:42 ` [PATCH 3/4] bfd: Output SH_LINK to .symtab for SHT_LLVM_ADDRSIG Tatsuyuki Ishi
2022-05-25  7:46   ` Jan Beulich [this message]
2022-05-25  6:42 ` [PATCH 4/4] gas: Add basic test for addrsig Tatsuyuki Ishi
2022-05-25  7:30   ` Alan Modra
2022-05-25  7:19 ` [PATCH 0/4] gas: Add support for LLVM addrsig and addrsig_sym Fangrui Song
2022-05-25  7:34   ` Alan Modra
2022-05-25  7:59     ` Fangrui Song
2022-05-25  8:01     ` Tatsuyuki Ishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae33c4b9-043d-b946-f541-6611b19a269e@suse.com \
    --to=jbeulich@suse.com \
    --cc=binutils@sourceware.org \
    --cc=ishitatsuyuki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).