public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>, Vineet Gupta <vineetg@rivosinc.com>
Subject: Re: [PATCH v2 0/3] RISC-V: Prepare Privileged Architecture 1.12
Date: Mon, 21 Feb 2022 22:38:57 +0900	[thread overview]
Message-ID: <268f323e-9f7a-2803-4b71-46506952fb52@irq.a4lg.com> (raw)
In-Reply-To: <77d4e5d6-5059-3f44-1ee9-8e2a6bfd3af3@suse.com>

On 2022/02/21 22:21, Jan Beulich wrote:
> On 24.12.2021 04:22, Tsukasa OI via Binutils wrote:
>> Tsukasa OI (3):
>>   RISC-V: Make testcase indentation consistent
>>   RISC-V: Unify "access all CSRs" testcases
>>   RISC-V: Add Privileged Architecture version 1.12
>>
>>  bfd/cpu-riscv.c                               |   1 +
>>  bfd/cpu-riscv.h                               |   1 +
>>  gas/config/tc-riscv.c                         |   2 +-
>>  gas/testsuite/gas/riscv/csr-dw-regnums.d      |   2 +-
>>  gas/testsuite/gas/riscv/option-arch-01a.d     |   8 +-
>>  gas/testsuite/gas/riscv/priv-reg-access-all.s | 292 ++++++++++
>>  gas/testsuite/gas/riscv/priv-reg-fail-fext.d  |   2 +-
>>  .../gas/riscv/priv-reg-fail-read-only-01.d    |   2 +-
>>  .../gas/riscv/priv-reg-fail-read-only-01.s    | 267 +--------
>>  .../gas/riscv/priv-reg-fail-read-only-02.d    |   2 +-
>>  .../gas/riscv/priv-reg-fail-rv32-only.d       |   2 +-
>>  .../gas/riscv/priv-reg-fail-version-1p10.d    |   2 +-
>>  .../gas/riscv/priv-reg-fail-version-1p11.d    |   2 +-
>>  .../gas/riscv/priv-reg-fail-version-1p12.d    |  11 +
>>  .../gas/riscv/priv-reg-fail-version-1p12.l    |  24 +
>>  .../gas/riscv/priv-reg-fail-version-1p9p1.d   |   2 +-
>>  gas/testsuite/gas/riscv/priv-reg-fail-zkr.d   |   2 +-
>>  .../gas/riscv/priv-reg-version-1p10.d         | 534 +++++++++---------
>>  .../gas/riscv/priv-reg-version-1p11.d         | 534 +++++++++---------
>>  .../gas/riscv/priv-reg-version-1p12.d         | 275 +++++++++
> 
> Comparing with the spec I find SCONTEXT still is numbered 0x7aa in here,
> when the doc says 0x5a8. Was this overlooked? Or is the doc wrong?
> 
> Jan

You pointed out that right but still, this is intentional.

In PATCH 3/6 commit message, I wrote:
> (except moved "scontext" and
> new "mscontext").

Because `scontext' is a part of debug specification (NOT privileged
specification), I thought it should be controlled by debug specification
version option like one proposed by Nelson Chu:

<https://sourceware.org/pipermail/binutils/2021-August/117568.html>

Note that debug specification 1.0 (with moved `scontext' and new
`mscontext') is not ratified yet.

<https://github.com/riscv/riscv-debug-spec/commit/b659d7dc7f578e1a2a76f9e62a5eec0f2d80045c>

Tsukasa

> 
>>  .../gas/riscv/priv-reg-version-1p9p1.d        | 534 +++++++++---------
>>  gas/testsuite/gas/riscv/priv-reg.s            | 294 +---------
>>  22 files changed, 1421 insertions(+), 1374 deletions(-)
>>  create mode 100644 gas/testsuite/gas/riscv/priv-reg-access-all.s
>>  create mode 100644 gas/testsuite/gas/riscv/priv-reg-fail-version-1p12.d
>>  create mode 100644 gas/testsuite/gas/riscv/priv-reg-fail-version-1p12.l
>>  create mode 100644 gas/testsuite/gas/riscv/priv-reg-version-1p12.d
>>
>>
>> base-commit: d20236e748ab70e9243960850eef64838f1b9721
> 

  reply	other threads:[~2022-02-21 13:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-24  3:22 Tsukasa OI
2021-12-24  3:22 ` [PATCH v2 1/3] RISC-V: Make testcase indentation consistent Tsukasa OI
2021-12-24  3:22 ` [PATCH v2 2/3] RISC-V: Unify "access all CSRs" testcases Tsukasa OI
2021-12-24  3:22 ` [PATCH v2 3/3] RISC-V: Add Privileged Architecture version 1.12 Tsukasa OI
2022-02-21 13:21 ` [PATCH v2 0/3] RISC-V: Prepare Privileged Architecture 1.12 Jan Beulich
2022-02-21 13:38   ` Tsukasa OI [this message]
2022-02-21 13:49     ` Tsukasa OI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=268f323e-9f7a-2803-4b71-46506952fb52@irq.a4lg.com \
    --to=research_trasio@irq.a4lg.com \
    --cc=binutils@sourceware.org \
    --cc=jbeulich@suse.com \
    --cc=vineetg@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).