From: Jan Beulich <jbeulich@suse.com>
To: "Joshi, Tejas Sanjay" <TejasSanjay.Joshi@amd.com>
Cc: "hjl.tools@gmail.com" <hjl.tools@gmail.com>,
"Gopalasubramanian, Ganesh" <Ganesh.Gopalasubramanian@amd.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH]
Date: Fri, 28 Oct 2022 10:15:00 +0200 [thread overview]
Message-ID: <28044500-4513-3d31-db60-946f873524ae@suse.com> (raw)
In-Reply-To: <DM6PR12MB4795A2C3C7043A4359BCDEAAE3329@DM6PR12MB4795.namprd12.prod.outlook.com>
On 28.10.2022 09:20, Joshi, Tejas Sanjay wrote:
> opcodes/
>
> * i386-dis.c (x86_64_table): Add rmpquery.
> * i386-gen.c (cpu_flag_init): Add CPU_ZNVER4_FLAGS and CpuRMPQUERY.
You also (afaict needlessly) add CPU_RMPQUERY_FLAGS, whereas CpuRMPQUERY
isn't applicable here; you already ...
> (cpu_flags): Add CpuRMPQUERY.
... mention it here, where it is applicable.
> * i386-opc.h (enum): Add CpuRMPQUERY.
> (i386_cpu_flags): Add cpurmpquery.
> * i386-opc.tbl: Add rmpquery insn.
The three relevant SNP insn have a comment: "The single-operand forms
exist only for compatibility with older gas." Therefore I'd like to ask
that new insns (like the one you add here) don't have that strange form
also added.
Other than these looks largely okay to me.
Note that commenting on patches would be easier if they were (also)
sent inline, not (just) as attachment(s).
Jan
next prev parent reply other threads:[~2022-10-28 8:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 7:20 [PATCH] Joshi, Tejas Sanjay
2022-10-28 7:22 ` [PATCH] Add znver4 processor support Joshi, Tejas Sanjay
2022-10-28 8:15 ` Jan Beulich [this message]
2022-10-28 15:45 ` [PATCH] H.J. Lu
2022-10-31 4:37 ` [PATCH] Joshi, Tejas Sanjay
2022-10-31 9:37 ` [PATCH] Jan Beulich
2022-11-08 10:18 ` [PATCH] Add znver4 processor support Jan Beulich
2022-11-09 7:14 ` Joshi, Tejas Sanjay
2022-11-09 20:18 ` H.J. Lu
2022-11-12 19:00 ` Joshi, Tejas Sanjay
2022-11-14 22:58 ` H.J. Lu
2022-11-15 5:20 ` Joshi, Tejas Sanjay
2022-11-15 16:12 ` H.J. Lu
2022-11-15 17:51 ` Joshi, Tejas Sanjay
-- strict thread matches above, loose matches on Subject: below --
2009-04-02 4:56 [PATCH] Peter Bergner
2009-04-02 7:01 ` [PATCH] Alan Modra
2003-04-28 17:50 problems re: makeinfo '--split-size' arg? cgd
2003-04-28 18:55 ` Joseph S. Myers
[not found] ` <mailpost.1051556216.2781@news-sj1-1>
2003-05-01 17:27 ` cgd
2003-05-02 6:23 ` Gerald Pfeifer
2003-05-02 21:44 ` [patch] cgd
2001-12-05 5:44 [PATCH] Jakub Jelinek
2001-12-06 2:26 ` [PATCH] Nick Clifton
2000-02-09 20:39 [PATCH] Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28044500-4513-3d31-db60-946f873524ae@suse.com \
--to=jbeulich@suse.com \
--cc=Ganesh.Gopalasubramanian@amd.com \
--cc=TejasSanjay.Joshi@amd.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).