From: Lulu Cai <cailulu@loongson.cn>
To: WANG Xuerui <i.swmail@xen0n.name>, binutils@sourceware.org
Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn,
liuzhensong@loongson.cn, mengqinggang@loongson.cn,
xry111@xry111.site, maskray@google.com, luweining@loongson.cn,
wanglei@loongson.cn, hejinyang@loongson.cn
Subject: Re: [PATCH v1] LoongArch: Scan all illegal operand instructions without interruption
Date: Wed, 6 Mar 2024 09:58:33 +0800 [thread overview]
Message-ID: <3556806e-c2f7-06ac-28eb-4ab8ccd40af3@loongson.cn> (raw)
In-Reply-To: <e8da4e63-27d1-45c9-a579-1b723af343f6@xen0n.name>
On 3/6/24 2:43 AM, WANG Xuerui wrote:
> On 3/5/24 19:35, Lulu Cai wrote:
>> Currently, gas will exit immediately and report an error when
>> it sees illegal operands, and will not process the remaining
>> instructions. Replace as_fatal with as_bad to check for all
>> illegal operands.
>>
>> Add test cases for illegal operands of some instructions.
>> ---
>> gas/config/tc-loongarch.c | 11 +-
>> .../gas/loongarch/check_bstrins-pick.d | 18 +++
>> .../gas/loongarch/check_bstrins-pick.s | 9 ++
>> gas/testsuite/gas/loongarch/illegal-oprand.l | 113 +++++++++++++++++
>> gas/testsuite/gas/loongarch/illegal-oprand.s | 117 ++++++++++++++++++
>
> The filename contains a typo: "operand" instead of "oprand".
>
Thanks for the reminder, I will revise it later.
>> gas/testsuite/gas/loongarch/loongarch.exp | 4 +
>> gas/testsuite/gas/loongarch/lvz-lbt.d | 2 +-
>> gas/testsuite/gas/loongarch/lvz-lbt.s | 2 +-
>> 8 files changed, 269 insertions(+), 7 deletions(-)
>> create mode 100644 gas/testsuite/gas/loongarch/check_bstrins-pick.d
>> create mode 100644 gas/testsuite/gas/loongarch/check_bstrins-pick.s
>> create mode 100644 gas/testsuite/gas/loongarch/illegal-oprand.l
>> create mode 100644 gas/testsuite/gas/loongarch/illegal-oprand.s
> Other than that, the code changes LGTM, thanks!
prev parent reply other threads:[~2024-03-06 1:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 11:35 Lulu Cai
2024-03-05 18:43 ` WANG Xuerui
2024-03-06 1:58 ` Lulu Cai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3556806e-c2f7-06ac-28eb-4ab8ccd40af3@loongson.cn \
--to=cailulu@loongson.cn \
--cc=binutils@sourceware.org \
--cc=chenglulu@loongson.cn \
--cc=hejinyang@loongson.cn \
--cc=i.swmail@xen0n.name \
--cc=liuzhensong@loongson.cn \
--cc=luweining@loongson.cn \
--cc=maskray@google.com \
--cc=mengqinggang@loongson.cn \
--cc=wanglei@loongson.cn \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).