* [PATCH] elf: Copy p_align of PT_GNU_STACK for stack alignment
@ 2022-07-05 19:50 H.J. Lu
2022-07-06 6:20 ` Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2022-07-05 19:50 UTC (permalink / raw)
To: binutils
commit 74e315dbfe5200c473b226e937935fb8ce391489
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Mon Dec 13 19:46:04 2021 -0800
elf: Set p_align to the minimum page size if possible
may ignore p_align of PT_GNU_STACK when copying ELF program header if
the maximum page size is larger than p_align of PT_LOAD segments. Copy
p_align of PT_GNU_STACK since p_align of PT_GNU_STACK describes stack
alignment, not page size,
PR binutils/29319
* elf.c (copy_elf_program_header): Copy p_align of PT_GNU_STACK
for stack alignment.
---
bfd/elf.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bfd/elf.c b/bfd/elf.c
index 468d37f5028..89484ceb233 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -7685,7 +7685,9 @@ copy_elf_program_header (bfd *ibfd, bfd *obfd)
map->p_paddr = segment->p_paddr;
map->p_paddr_valid = p_paddr_valid;
map->p_align = segment->p_align;
- map->p_align_valid = p_palign_valid;
+ /* Keep p_align of PT_GNU_STACK for stack alignment. */
+ map->p_align_valid = (map->p_type == PT_GNU_STACK
+ || p_palign_valid);
map->p_vaddr_offset = 0;
if (map->p_type == PT_GNU_RELRO
--
2.36.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] elf: Copy p_align of PT_GNU_STACK for stack alignment
2022-07-05 19:50 [PATCH] elf: Copy p_align of PT_GNU_STACK for stack alignment H.J. Lu
@ 2022-07-06 6:20 ` Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: Jan Beulich @ 2022-07-06 6:20 UTC (permalink / raw)
To: H.J. Lu; +Cc: binutils
On 05.07.2022 21:50, H.J. Lu via Binutils wrote:
> commit 74e315dbfe5200c473b226e937935fb8ce391489
> Author: H.J. Lu <hjl.tools@gmail.com>
> Date: Mon Dec 13 19:46:04 2021 -0800
>
> elf: Set p_align to the minimum page size if possible
>
> may ignore p_align of PT_GNU_STACK when copying ELF program header if
> the maximum page size is larger than p_align of PT_LOAD segments. Copy
> p_align of PT_GNU_STACK since p_align of PT_GNU_STACK describes stack
> alignment, not page size,
>
> PR binutils/29319
> * elf.c (copy_elf_program_header): Copy p_align of PT_GNU_STACK
> for stack alignment.
> ---
> bfd/elf.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/bfd/elf.c b/bfd/elf.c
> index 468d37f5028..89484ceb233 100644
> --- a/bfd/elf.c
> +++ b/bfd/elf.c
> @@ -7685,7 +7685,9 @@ copy_elf_program_header (bfd *ibfd, bfd *obfd)
> map->p_paddr = segment->p_paddr;
> map->p_paddr_valid = p_paddr_valid;
> map->p_align = segment->p_align;
> - map->p_align_valid = p_palign_valid;
> + /* Keep p_align of PT_GNU_STACK for stack alignment. */
> + map->p_align_valid = (map->p_type == PT_GNU_STACK
> + || p_palign_valid);
> map->p_vaddr_offset = 0;
>
> if (map->p_type == PT_GNU_RELRO
OK.
Jan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-06 6:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-05 19:50 [PATCH] elf: Copy p_align of PT_GNU_STACK for stack alignment H.J. Lu
2022-07-06 6:20 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).