public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* PATCH: gas/2598: Build kernel 2.6.16 modules with gcc 4.0.2 Warning: setting incorrect section attributes for .got
@ 2006-04-26  3:45 H. J. Lu
  2006-04-26  9:24 ` H. J. Lu
  0 siblings, 1 reply; 3+ messages in thread
From: H. J. Lu @ 2006-04-26  3:45 UTC (permalink / raw)
  To: binutils

Gcc may generate a section with SHF_ALPHA_GPREL. Assembler shouldn't
complain. This patch does it.


H.J.
----
2006-04-25  H.J. Lu  <hongjiu.lu@intel.com>

	PR gas/2598
	* config/obj-elf.c (obj_elf_change_section): Allow user
	specified SHF_ALPHA_GPREL.

--- gas/config/obj-elf.c.alpha	2005-09-26 12:13:55.000000000 -0700
+++ gas/config/obj-elf.c	2006-04-25 15:21:15.000000000 -0700
@@ -632,6 +632,11 @@ obj_elf_change_section (const char *name
 	  else if (attr == SHF_EXECINSTR
 		   && strcmp (name, ".note.GNU-stack") == 0)
 	    override = TRUE;
+#ifdef TC_ALPHA
+	  /* A section on Alpha can have SHF_ALPHA_GPREL.  */
+	  else if ((attr & SHF_ALPHA_GPREL))
+	    override = TRUE;
+#endif
 	  else
 	    {
 	      if (group_name == NULL)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: PATCH: gas/2598: Build kernel 2.6.16 modules with gcc 4.0.2 Warning: setting incorrect section attributes for .got
  2006-04-26  3:45 PATCH: gas/2598: Build kernel 2.6.16 modules with gcc 4.0.2 Warning: setting incorrect section attributes for .got H. J. Lu
@ 2006-04-26  9:24 ` H. J. Lu
  2006-05-05 18:39   ` Nick Clifton
  0 siblings, 1 reply; 3+ messages in thread
From: H. J. Lu @ 2006-04-26  9:24 UTC (permalink / raw)
  To: binutils

On Tue, Apr 25, 2006 at 03:26:18PM -0700, H. J. Lu wrote:
> Gcc may generate a section with SHF_ALPHA_GPREL. Assembler shouldn't
> complain. This patch does it.
> 
> 

I am not really sure if SHF_ALPHA_GPREL is really needed. This is the
updated patch to properly allow it.


H.J.
---
2006-04-25  H.J. Lu  <hongjiu.lu@intel.com>

	PR gas/2598
	* config/obj-elf.c (obj_elf_change_section): Allow user
	specified SHF_ALPHA_GPREL.

--- gas/config/obj-elf.c.alpha	2005-09-26 12:13:55.000000000 -0700
+++ gas/config/obj-elf.c	2006-04-25 18:16:36.000000000 -0700
@@ -632,6 +632,11 @@ obj_elf_change_section (const char *name
 	  else if (attr == SHF_EXECINSTR
 		   && strcmp (name, ".note.GNU-stack") == 0)
 	    override = TRUE;
+#ifdef TC_ALPHA
+	  /* A section on Alpha may have SHF_ALPHA_GPREL.  */
+	  else if ((attr & ~ssect->attr) == SHF_ALPHA_GPREL)
+	    override = TRUE;
+#endif
 	  else
 	    {
 	      if (group_name == NULL)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: PATCH: gas/2598: Build kernel 2.6.16 modules with gcc 4.0.2 Warning:  setting incorrect section attributes for .got
  2006-04-26  9:24 ` H. J. Lu
@ 2006-05-05 18:39   ` Nick Clifton
  0 siblings, 0 replies; 3+ messages in thread
From: Nick Clifton @ 2006-05-05 18:39 UTC (permalink / raw)
  To: H. J. Lu; +Cc: binutils

Hi H. J.

> 2006-04-25  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR gas/2598
> 	* config/obj-elf.c (obj_elf_change_section): Allow user
> 	specified SHF_ALPHA_GPREL.

Approved - please apply.

Cheers
   Nick

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-05-05 17:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-04-26  3:45 PATCH: gas/2598: Build kernel 2.6.16 modules with gcc 4.0.2 Warning: setting incorrect section attributes for .got H. J. Lu
2006-04-26  9:24 ` H. J. Lu
2006-05-05 18:39   ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).