* [PATCH] LoongArch: Fix bug "PACKAGE" redefined.
@ 2022-08-30 6:43 liuzhensong
2022-08-30 10:05 ` Jan-Benedict Glaw
2022-08-30 10:18 ` WANG Xuerui
0 siblings, 2 replies; 3+ messages in thread
From: liuzhensong @ 2022-08-30 6:43 UTC (permalink / raw)
To: binutils; +Cc: jbglaw, liuzhensong
Running configure and make in binutils-gdb.
$ ./configure
$ make
In file included from ./as.h:37,
from ./config/loongarch-lex.l:21,
from config/loongarch-lex-wrapper.c:20:
./config.h:206: error: “PACKAGE” redefined [-Werror]
#define PACKAGE "gas"
...
gas/config
* loongarch-lex-wrapper.c
---
gas/config/loongarch-lex-wrapper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gas/config/loongarch-lex-wrapper.c b/gas/config/loongarch-lex-wrapper.c
index 3bb0b14c680..4ddeeb73c9b 100644
--- a/gas/config/loongarch-lex-wrapper.c
+++ b/gas/config/loongarch-lex-wrapper.c
@@ -16,5 +16,5 @@
along with this program; see the file COPYING3. If not,
see <http://www.gnu.org/licenses/>. */
-#include "sysdep.h"
+#include "config.h"
#include "config/loongarch-lex.c"
--
2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] LoongArch: Fix bug "PACKAGE" redefined.
2022-08-30 6:43 [PATCH] LoongArch: Fix bug "PACKAGE" redefined liuzhensong
@ 2022-08-30 10:05 ` Jan-Benedict Glaw
2022-08-30 10:18 ` WANG Xuerui
1 sibling, 0 replies; 3+ messages in thread
From: Jan-Benedict Glaw @ 2022-08-30 10:05 UTC (permalink / raw)
To: liuzhensong; +Cc: binutils
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Tue, 2022-08-30 14:43:11 +0800, liuzhensong <liuzhensong@loongson.cn> wrote:
> Running configure and make in binutils-gdb.
[...]
> diff --git a/gas/config/loongarch-lex-wrapper.c b/gas/config/loongarch-lex-wrapper.c
> index 3bb0b14c680..4ddeeb73c9b 100644
> --- a/gas/config/loongarch-lex-wrapper.c
> +++ b/gas/config/loongarch-lex-wrapper.c
> @@ -16,5 +16,5 @@
> along with this program; see the file COPYING3. If not,
> see <http://www.gnu.org/licenses/>. */
>
> -#include "sysdep.h"
> +#include "config.h"
> #include "config/loongarch-lex.c"
Confirmed: That fixes the build issue.
Thanks,
Jan-Benedict
--
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] LoongArch: Fix bug "PACKAGE" redefined.
2022-08-30 6:43 [PATCH] LoongArch: Fix bug "PACKAGE" redefined liuzhensong
2022-08-30 10:05 ` Jan-Benedict Glaw
@ 2022-08-30 10:18 ` WANG Xuerui
1 sibling, 0 replies; 3+ messages in thread
From: WANG Xuerui @ 2022-08-30 10:18 UTC (permalink / raw)
To: liuzhensong, binutils
On 2022/8/30 14:43, liuzhensong wrote:
> Running configure and make in binutils-gdb.
>
> $ ./configure
> $ make
> In file included from ./as.h:37,
> from ./config/loongarch-lex.l:21,
> from config/loongarch-lex-wrapper.c:20:
> ./config.h:206: error: “PACKAGE” redefined [-Werror]
> #define PACKAGE "gas"
> ...
>
> gas/config
> * loongarch-lex-wrapper.c
> ---
> gas/config/loongarch-lex-wrapper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The patch title could be simply "Fix redefinition of PACKAGE".
Otherwise okay.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-30 10:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-30 6:43 [PATCH] LoongArch: Fix bug "PACKAGE" redefined liuzhensong
2022-08-30 10:05 ` Jan-Benedict Glaw
2022-08-30 10:18 ` WANG Xuerui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).