* [PATCH] gold: don't invoke IA32 syscall in x86_64 assembly testcase
@ 2022-03-12 14:21 Xi Ruoyao
2022-03-31 10:21 ` Xi Ruoyao
2022-03-31 10:41 ` Jan Beulich
0 siblings, 2 replies; 9+ messages in thread
From: Xi Ruoyao @ 2022-03-12 14:21 UTC (permalink / raw)
To: binutils
pr17704a_test.s is a x86_64 assembly file, but it invokes IA32 exit
syscall with "int 0x80". This causes a segfault on kernels with
CONFIG_IA32_EMULATION disabled.
gold/
* testsuite/pr17704a_test.s (_start): Invoke x86_64 exit syscall
instead of its IA32 counterpart.
---
gold/testsuite/pr17704a_test.s | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/gold/testsuite/pr17704a_test.s b/gold/testsuite/pr17704a_test.s
index 2b39e649f9e..8a645496faf 100644
--- a/gold/testsuite/pr17704a_test.s
+++ b/gold/testsuite/pr17704a_test.s
@@ -14,10 +14,10 @@ _start:
leaq bar(%rip), %rsi
testb $1, %sil
je .L9
- mov $1, %eax
- mov $1, %ebx
- int $0x80
+ mov $60, %rax
+ mov $1, %rdi
+ syscall
.L9:
- mov $1, %eax
- mov $0, %ebx
- int $0x80
+ mov $60, %rax
+ mov $0, %rdi
+ syscall
--
2.35.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gold: don't invoke IA32 syscall in x86_64 assembly testcase
2022-03-12 14:21 [PATCH] gold: don't invoke IA32 syscall in x86_64 assembly testcase Xi Ruoyao
@ 2022-03-31 10:21 ` Xi Ruoyao
2022-03-31 10:41 ` Jan Beulich
1 sibling, 0 replies; 9+ messages in thread
From: Xi Ruoyao @ 2022-03-31 10:21 UTC (permalink / raw)
To: binutils
Ping?
On Sat, 2022-03-12 at 22:21 +0800, Xi Ruoyao wrote:
> pr17704a_test.s is a x86_64 assembly file, but it invokes IA32 exit
> syscall with "int 0x80". This causes a segfault on kernels with
> CONFIG_IA32_EMULATION disabled.
>
> gold/
>
> * testsuite/pr17704a_test.s (_start): Invoke x86_64 exit syscall
> instead of its IA32 counterpart.
> ---
> gold/testsuite/pr17704a_test.s | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/gold/testsuite/pr17704a_test.s b/gold/testsuite/pr17704a_test.s
> index 2b39e649f9e..8a645496faf 100644
> --- a/gold/testsuite/pr17704a_test.s
> +++ b/gold/testsuite/pr17704a_test.s
> @@ -14,10 +14,10 @@ _start:
> leaq bar(%rip), %rsi
> testb $1, %sil
> je .L9
> - mov $1, %eax
> - mov $1, %ebx
> - int $0x80
> + mov $60, %rax
> + mov $1, %rdi
> + syscall
> .L9:
> - mov $1, %eax
> - mov $0, %ebx
> - int $0x80
> + mov $60, %rax
> + mov $0, %rdi
> + syscall
--
Xi Ruoyao <xry111@mengyan1223.wang>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gold: don't invoke IA32 syscall in x86_64 assembly testcase
2022-03-12 14:21 [PATCH] gold: don't invoke IA32 syscall in x86_64 assembly testcase Xi Ruoyao
2022-03-31 10:21 ` Xi Ruoyao
@ 2022-03-31 10:41 ` Jan Beulich
2022-03-31 15:03 ` Xi Ruoyao
1 sibling, 1 reply; 9+ messages in thread
From: Jan Beulich @ 2022-03-31 10:41 UTC (permalink / raw)
To: Xi Ruoyao; +Cc: binutils
On 12.03.2022 15:21, Xi Ruoyao via Binutils wrote:
> pr17704a_test.s is a x86_64 assembly file, but it invokes IA32 exit
> syscall with "int 0x80". This causes a segfault on kernels with
> CONFIG_IA32_EMULATION disabled.
>
> gold/
>
> * testsuite/pr17704a_test.s (_start): Invoke x86_64 exit syscall
> instead of its IA32 counterpart.
Okay.
Thanks, Jan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gold: don't invoke IA32 syscall in x86_64 assembly testcase
2022-03-31 10:41 ` Jan Beulich
@ 2022-03-31 15:03 ` Xi Ruoyao
2022-03-31 16:05 ` Cary Coutant
0 siblings, 1 reply; 9+ messages in thread
From: Xi Ruoyao @ 2022-03-31 15:03 UTC (permalink / raw)
To: Jan Beulich; +Cc: binutils
On Thu, 2022-03-31 at 12:41 +0200, Jan Beulich wrote:
> On 12.03.2022 15:21, Xi Ruoyao via Binutils wrote:
> > pr17704a_test.s is a x86_64 assembly file, but it invokes IA32 exit
> > syscall with "int 0x80". This causes a segfault on kernels with
> > CONFIG_IA32_EMULATION disabled.
> >
> > gold/
> >
> > * testsuite/pr17704a_test.s (_start): Invoke x86_64 exit syscall
> > instead of its IA32 counterpart.
>
> Okay.
I don't have write access to binutils-gdb.git, please help me to push
it.
--
Xi Ruoyao <xry111@mengyan1223.wang>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gold: don't invoke IA32 syscall in x86_64 assembly testcase
2022-03-31 15:03 ` Xi Ruoyao
@ 2022-03-31 16:05 ` Cary Coutant
2022-04-08 23:25 ` Xi Ruoyao
0 siblings, 1 reply; 9+ messages in thread
From: Cary Coutant @ 2022-03-31 16:05 UTC (permalink / raw)
To: Xi Ruoyao; +Cc: Jan Beulich, binutils
> On Thu, 2022-03-31 at 12:41 +0200, Jan Beulich wrote:
> > On 12.03.2022 15:21, Xi Ruoyao via Binutils wrote:
> > > pr17704a_test.s is a x86_64 assembly file, but it invokes IA32 exit
> > > syscall with "int 0x80". This causes a segfault on kernels with
> > > CONFIG_IA32_EMULATION disabled.
> > >
> > > gold/
> > >
> > > * testsuite/pr17704a_test.s (_start): Invoke x86_64 exit syscall
> > > instead of its IA32 counterpart.
> >
> > Okay.
>
> I don't have write access to binutils-gdb.git, please help me to push
> it.
Sorry, yes, this is OK. I'll apply it.
-cary
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gold: don't invoke IA32 syscall in x86_64 assembly testcase
2022-03-31 16:05 ` Cary Coutant
@ 2022-04-08 23:25 ` Xi Ruoyao
2022-04-28 16:15 ` [PING^2 PATCH] " Xi Ruoyao
0 siblings, 1 reply; 9+ messages in thread
From: Xi Ruoyao @ 2022-04-08 23:25 UTC (permalink / raw)
To: Cary Coutant; +Cc: Jan Beulich, binutils
On Thu, 2022-03-31 at 09:05 -0700, Cary Coutant wrote:
> > On Thu, 2022-03-31 at 12:41 +0200, Jan Beulich wrote:
> > > On 12.03.2022 15:21, Xi Ruoyao via Binutils wrote:
> > > > pr17704a_test.s is a x86_64 assembly file, but it invokes IA32
> > > > exit
> > > > syscall with "int 0x80". This causes a segfault on kernels with
> > > > CONFIG_IA32_EMULATION disabled.
> > > >
> > > > gold/
> > > >
> > > > * testsuite/pr17704a_test.s (_start): Invoke x86_64 exit
> > > > syscall
> > > > instead of its IA32 counterpart.
> > >
> > > Okay.
> >
> > I don't have write access to binutils-gdb.git, please help me to
> > push
> > it.
>
> Sorry, yes, this is OK. I'll apply it.
>
> -cary
Gentle ping again, in case it's forgotten :).
--
Xi Ruoyao <xry111@mengyan1223.wang>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PING^2 PATCH] gold: don't invoke IA32 syscall in x86_64 assembly testcase
2022-04-08 23:25 ` Xi Ruoyao
@ 2022-04-28 16:15 ` Xi Ruoyao
2022-05-06 15:03 ` [PING^3 " Xi Ruoyao
0 siblings, 1 reply; 9+ messages in thread
From: Xi Ruoyao @ 2022-04-28 16:15 UTC (permalink / raw)
To: Cary Coutant; +Cc: Jan Beulich, binutils
On Sat, 2022-04-09 at 07:25 +0800, Xi Ruoyao wrote:
> On Thu, 2022-03-31 at 09:05 -0700, Cary Coutant wrote:
> > > On Thu, 2022-03-31 at 12:41 +0200, Jan Beulich wrote:
> > > > On 12.03.2022 15:21, Xi Ruoyao via Binutils wrote:
> > > > > pr17704a_test.s is a x86_64 assembly file, but it invokes IA32
> > > > > exit
> > > > > syscall with "int 0x80". This causes a segfault on kernels
> > > > > with
> > > > > CONFIG_IA32_EMULATION disabled.
> > > > >
> > > > > gold/
> > > > >
> > > > > * testsuite/pr17704a_test.s (_start): Invoke x86_64
> > > > > exit
> > > > > syscall
> > > > > instead of its IA32 counterpart.
> > > >
> > > > Okay.
> > >
> > > I don't have write access to binutils-gdb.git, please help me to
> > > push
> > > it.
> >
> > Sorry, yes, this is OK. I'll apply it.
> >
> > -cary
>
> Gentle ping again, in case it's forgotten :).
Ping? :(
--
Xi Ruoyao <xry111@mengyan1223.wang>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PING^3 PATCH] gold: don't invoke IA32 syscall in x86_64 assembly testcase
2022-04-28 16:15 ` [PING^2 PATCH] " Xi Ruoyao
@ 2022-05-06 15:03 ` Xi Ruoyao
2022-05-18 7:40 ` Jan Beulich
0 siblings, 1 reply; 9+ messages in thread
From: Xi Ruoyao @ 2022-05-06 15:03 UTC (permalink / raw)
To: binutils
On Fri, 2022-04-29 at 00:15 +0800, Xi Ruoyao wrote:
> On Sat, 2022-04-09 at 07:25 +0800, Xi Ruoyao wrote:
> > On Thu, 2022-03-31 at 09:05 -0700, Cary Coutant wrote:
> > > > On Thu, 2022-03-31 at 12:41 +0200, Jan Beulich wrote:
> > > > > On 12.03.2022 15:21, Xi Ruoyao via Binutils wrote:
> > > > > > pr17704a_test.s is a x86_64 assembly file, but it invokes
> > > > > > IA32
> > > > > > exit
> > > > > > syscall with "int 0x80". This causes a segfault on kernels
> > > > > > with
> > > > > > CONFIG_IA32_EMULATION disabled.
> > > > > >
> > > > > > gold/
> > > > > >
> > > > > > * testsuite/pr17704a_test.s (_start): Invoke x86_64
> > > > > > exit
> > > > > > syscall
> > > > > > instead of its IA32 counterpart.
> > > > >
> > > > > Okay.
> > > >
> > > > I don't have write access to binutils-gdb.git, please help me to
> > > > push
> > > > it.
> > >
> > > Sorry, yes, this is OK. I'll apply it.
> > >
> > > -cary
> >
> > Gentle ping again, in case it's forgotten :).
>
> Ping? :(
Ping.
--
Xi Ruoyao <xry111@mengyan1223.wang>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PING^3 PATCH] gold: don't invoke IA32 syscall in x86_64 assembly testcase
2022-05-06 15:03 ` [PING^3 " Xi Ruoyao
@ 2022-05-18 7:40 ` Jan Beulich
0 siblings, 0 replies; 9+ messages in thread
From: Jan Beulich @ 2022-05-18 7:40 UTC (permalink / raw)
To: Xi Ruoyao; +Cc: Cary Coutant, binutils
On 06.05.2022 17:03, Xi Ruoyao wrote:
> On Fri, 2022-04-29 at 00:15 +0800, Xi Ruoyao wrote:
>> On Sat, 2022-04-09 at 07:25 +0800, Xi Ruoyao wrote:
>>> On Thu, 2022-03-31 at 09:05 -0700, Cary Coutant wrote:
>>>>> On Thu, 2022-03-31 at 12:41 +0200, Jan Beulich wrote:
>>>>>> On 12.03.2022 15:21, Xi Ruoyao via Binutils wrote:
>>>>>>> pr17704a_test.s is a x86_64 assembly file, but it invokes
>>>>>>> IA32
>>>>>>> exit
>>>>>>> syscall with "int 0x80". This causes a segfault on kernels
>>>>>>> with
>>>>>>> CONFIG_IA32_EMULATION disabled.
>>>>>>>
>>>>>>> gold/
>>>>>>>
>>>>>>> * testsuite/pr17704a_test.s (_start): Invoke x86_64
>>>>>>> exit
>>>>>>> syscall
>>>>>>> instead of its IA32 counterpart.
>>>>>>
>>>>>> Okay.
>>>>>
>>>>> I don't have write access to binutils-gdb.git, please help me to
>>>>> push
>>>>> it.
>>>>
>>>> Sorry, yes, this is OK. I'll apply it.
>>>>
>>>> -cary
>>>
>>> Gentle ping again, in case it's forgotten :).
>>
>> Ping? :(
>
> Ping.
I've committed this, seeing that it was still pending. While doing so
I took the liberty to slightly change the new assembly (using %eax
instead of %rax in two places).
Jan
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-05-18 7:40 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-12 14:21 [PATCH] gold: don't invoke IA32 syscall in x86_64 assembly testcase Xi Ruoyao
2022-03-31 10:21 ` Xi Ruoyao
2022-03-31 10:41 ` Jan Beulich
2022-03-31 15:03 ` Xi Ruoyao
2022-03-31 16:05 ` Cary Coutant
2022-04-08 23:25 ` Xi Ruoyao
2022-04-28 16:15 ` [PING^2 PATCH] " Xi Ruoyao
2022-05-06 15:03 ` [PING^3 " Xi Ruoyao
2022-05-18 7:40 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).