[PATCH 1/2] ld: Fix relocatable.d XFAIL/notarget entry for hppa

[PATCH 1/2] ld: Fix relocatable.d XFAIL/notarget entry for hppa

[Sam James]

PR 30734
* ld/testsuite/ld-elf/relocatable.d: Fix notarget entry for hppa to match
  hppa{1.1,2.0}*, like hppa2.0-unknown-linux-gnu which Gentoo uses.

Signed-off-by: Sam James <sam@gentoo.org>
---
 ld/testsuite/ld-elf/relocatable.d | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ld/testsuite/ld-elf/relocatable.d b/ld/testsuite/ld-elf/relocatable.d
index d0fba97a104..cb39baa52bc 100644
--- a/ld/testsuite/ld-elf/relocatable.d
+++ b/ld/testsuite/ld-elf/relocatable.d
@@ -2,7 +2,7 @@
 #source: simple.s
 #ld: -r -T relocatable.t
 #readelf: -S --wide
-#xfail: hppa-*-*
+#xfail: hppa*-*-*
 
 #...
   \[[ 0-9]+\] \.text.*[ \t]+PROGBITS[ \t]+0+800000[ \t0-9a-f]+AX.*
-- 
2.41.0

[PATCH 2/2] ld: Fix retain7a.d XFAIL/notarget entry for hppa

[Sam James]

PR 30733
* ld/testsuite/ld-elf/retain7a.d: Fix XFAIL entry for hppa to match
  hppa{1.1,2.0}*, like hppa2.0-unknown-linux-gnu which Gentoo uses.

Signed-off-by: Sam James <sam@gentoo.org>
---
 ld/testsuite/ld-elf/retain7a.d | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ld/testsuite/ld-elf/retain7a.d b/ld/testsuite/ld-elf/retain7a.d
index 314fe0f5733..38d9a9ba255 100644
--- a/ld/testsuite/ld-elf/retain7a.d
+++ b/ld/testsuite/ld-elf/retain7a.d
@@ -2,7 +2,7 @@
 #source: retain7.s
 #ld: -e _start --gc-sections
 # hppa-linux chooses ELFOSABI_GNU regardless of GNU feature use
-#notarget: ![supports_gnu_osabi] ![check_gc_sections_available] hppa-*-linux*
+#notarget: ![supports_gnu_osabi] ![check_gc_sections_available] hppa*-*-linux*
 #readelf: -h
 
 #failif
-- 
2.41.0

Re: [PATCH 1/2] ld: Fix relocatable.d XFAIL/notarget entry for hppa

[Jan Beulich]

On 08.08.2023 03:23, Sam James via Binutils wrote:
> PR 30734
> * ld/testsuite/ld-elf/relocatable.d: Fix notarget entry for hppa to match
>   hppa{1.1,2.0}*, like hppa2.0-unknown-linux-gnu which Gentoo uses.
> 
> Signed-off-by: Sam James <sam@gentoo.org>

Since the two patches deal with the only two outliers, I'd consider these
to be at least very close to obvious. Feel free to put in. Yet in the
future for arch-specific changes please remember to Cc respective arch
maintainers.

Jan

Re: [PATCH 1/2] ld: Fix relocatable.d XFAIL/notarget entry for hppa

[Sam James]

Jan Beulich <jbeulich@suse.com> writes:

> On 08.08.2023 03:23, Sam James via Binutils wrote:
>> PR 30734
>> * ld/testsuite/ld-elf/relocatable.d: Fix notarget entry for hppa to match
>>   hppa{1.1,2.0}*, like hppa2.0-unknown-linux-gnu which Gentoo uses.
>> 
>> Signed-off-by: Sam James <sam@gentoo.org>
>
> Since the two patches deal with the only two outliers, I'd consider these
> to be at least very close to obvious. Feel free to put in. Yet in the
> future for arch-specific changes please remember to Cc respective arch
> maintainers.

1. ACK, pushed. Thank you. Sorry, I was a bit too conservative here.
2. Fair point, I will do this in future.

What's the rule for backports? Can I just do those if obvious? What
about if they're not my commits but I've tested them and they're
straightforward?

best,
sam

Re: [PATCH 1/2] ld: Fix relocatable.d XFAIL/notarget entry for hppa

[Alan Modra]

On Tue, Aug 08, 2023 at 02:23:59AM +0100, Sam James via Binutils wrote:
> PR 30734
> * ld/testsuite/ld-elf/relocatable.d: Fix notarget entry for hppa to match
>   hppa{1.1,2.0}*, like hppa2.0-unknown-linux-gnu which Gentoo uses.
> 
> Signed-off-by: Sam James <sam@gentoo.org>
> ---
>  ld/testsuite/ld-elf/relocatable.d | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ld/testsuite/ld-elf/relocatable.d b/ld/testsuite/ld-elf/relocatable.d
> index d0fba97a104..cb39baa52bc 100644
> --- a/ld/testsuite/ld-elf/relocatable.d
> +++ b/ld/testsuite/ld-elf/relocatable.d
> @@ -2,7 +2,7 @@
>  #source: simple.s
>  #ld: -r -T relocatable.t
>  #readelf: -S --wide
> -#xfail: hppa-*-*
> +#xfail: hppa*-*-*
>  
>  #...
>    \[[ 0-9]+\] \.text.*[ \t]+PROGBITS[ \t]+0+800000[ \t0-9a-f]+AX.*
> -- 
> 2.41.0

hppa64-hp-hpux11.23  +XPASS: relocatable with script
hppa64-linux-gnu  +XPASS: relocatable with script

-- 
Alan Modra
Australia Development Lab, IBM

Re: [PATCH 1/2] ld: Fix relocatable.d XFAIL/notarget entry for hppa

[Jan Beulich]

On 08.08.2023 19:53, Sam James wrote:
> 
> Jan Beulich <jbeulich@suse.com> writes:
> 
>> On 08.08.2023 03:23, Sam James via Binutils wrote:
>>> PR 30734
>>> * ld/testsuite/ld-elf/relocatable.d: Fix notarget entry for hppa to match
>>>   hppa{1.1,2.0}*, like hppa2.0-unknown-linux-gnu which Gentoo uses.
>>>
>>> Signed-off-by: Sam James <sam@gentoo.org>
>>
>> Since the two patches deal with the only two outliers, I'd consider these
>> to be at least very close to obvious. Feel free to put in. Yet in the
>> future for arch-specific changes please remember to Cc respective arch
>> maintainers.
> 
> 1. ACK, pushed. Thank you. Sorry, I was a bit too conservative here.
> 2. Fair point, I will do this in future.
> 
> What's the rule for backports? Can I just do those if obvious?

Unless while the tree is closed, I'd say generally yes, but after waiting
a little (to see whether there's fallout nevertheless, as appears to be
the case here). Of course it also doesn't hurt asking.

> What
> about if they're not my commits but I've tested them and they're
> straightforward?

I'm less sure here - I, for one, would ask in such a case, despite (now)
being global maintainer.

Jan

Re: [PATCH 1/2] ld: Fix relocatable.d XFAIL/notarget entry for hppa

[Sam James]

Alan Modra <amodra@gmail.com> writes:

> On Tue, Aug 08, 2023 at 02:23:59AM +0100, Sam James via Binutils wrote:
>> PR 30734
>> * ld/testsuite/ld-elf/relocatable.d: Fix notarget entry for hppa to match
>>   hppa{1.1,2.0}*, like hppa2.0-unknown-linux-gnu which Gentoo uses.
>> 
>> Signed-off-by: Sam James <sam@gentoo.org>
>> ---
>>  ld/testsuite/ld-elf/relocatable.d | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/ld/testsuite/ld-elf/relocatable.d b/ld/testsuite/ld-elf/relocatable.d
>> index d0fba97a104..cb39baa52bc 100644
>> --- a/ld/testsuite/ld-elf/relocatable.d
>> +++ b/ld/testsuite/ld-elf/relocatable.d
>> @@ -2,7 +2,7 @@
>>  #source: simple.s
>>  #ld: -r -T relocatable.t
>>  #readelf: -S --wide
>> -#xfail: hppa-*-*
>> +#xfail: hppa*-*-*
>>  
>>  #...
>>    \[[ 0-9]+\] \.text.*[ \t]+PROGBITS[ \t]+0+800000[ \t0-9a-f]+AX.*
>> -- 
>> 2.41.0
>
> hppa64-hp-hpux11.23  +XPASS: relocatable with script
> hppa64-linux-gnu  +XPASS: relocatable with script

Will fix on weekend, thanks, and apologies Alan.

I didn't want to have to expand with Gentoo's CHOSTs for 32-bit
but I think it should be fine, as we then cover both Linux
distributions which do HPPA (Debian already w/ hppa-*, and Gentoo
with hppa1.1/hppa2.0).

thanks,
sam

Re: [PATCH 1/2] ld: Fix relocatable.d XFAIL/notarget entry for hppa

[Sam James]

Jan Beulich <jbeulich@suse.com> writes:

> On 08.08.2023 19:53, Sam James wrote:
>> 
>> Jan Beulich <jbeulich@suse.com> writes:
>> 
>>> On 08.08.2023 03:23, Sam James via Binutils wrote:
>>>> PR 30734
>>>> * ld/testsuite/ld-elf/relocatable.d: Fix notarget entry for hppa to match
>>>>   hppa{1.1,2.0}*, like hppa2.0-unknown-linux-gnu which Gentoo uses.
>>>>
>>>> Signed-off-by: Sam James <sam@gentoo.org>
>>>
>>> Since the two patches deal with the only two outliers, I'd consider these
>>> to be at least very close to obvious. Feel free to put in. Yet in the
>>> future for arch-specific changes please remember to Cc respective arch
>>> maintainers.
>> 
>> 1. ACK, pushed. Thank you. Sorry, I was a bit too conservative here.
>> 2. Fair point, I will do this in future.
>> 
>> What's the rule for backports? Can I just do those if obvious?
>
> Unless while the tree is closed, I'd say generally yes, but after waiting
> a little (to see whether there's fallout nevertheless, as appears to be
> the case here). Of course it also doesn't hurt asking.
>
>> What
>> about if they're not my commits but I've tested them and they're
>> straightforward?
>
> I'm less sure here - I, for one, would ask in such a case, despite (now)
> being global maintainer.

Thank you for the advice Jan!