From: Andreas Schwab <schwab@linux-m68k.org>
To: Dmitry Selyutin via Binutils <binutils@sourceware.org>
Cc: Dmitry Selyutin <ghostmansd@gmail.com>,
Luke Kenneth Casson Leighton <lkcl@lkcl.net>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gas/write: extend fx_pcrel_adjust to 16 bits
Date: Wed, 11 May 2022 20:13:20 +0200 [thread overview]
Message-ID: <87y1z8szsv.fsf@igel.home> (raw)
In-Reply-To: <CAMqzjeuzs51B_f8oRAVPym0zu8=Nr5xhbaH1BJCnVhjhqPF31w@mail.gmail.com> (Dmitry Selyutin via Binutils's message of "Wed, 11 May 2022 20:59:24 +0300")
On Mai 11 2022, Dmitry Selyutin via Binutils wrote:
> diff --git a/gas/write.h b/gas/write.h
> index 501bdd828f..e31a0f5955 100644
> --- a/gas/write.h
> +++ b/gas/write.h
> @@ -73,10 +73,10 @@ struct fix
> unsigned fx_tcbit2 : 1;
>
> /* Spare bits. */
> - unsigned fx_unused : 10;
> + unsigned fx_unused : 2;
>
> /* pc-relative offset adjust (only used by some CPU specific code) */
> - int fx_pcrel_adjust : 8;
> + int fx_pcrel_adjust : 16;
>
> /* How many bytes are involved? */
> unsigned fx_size : 8;
It's probably better to swap the fx_size and fx_pcrel_adjust fields, so
that fx_pcrel_adjust is aligned on a 16 bit boundary.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2022-05-11 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 17:59 Dmitry Selyutin
2022-05-11 18:13 ` Andreas Schwab [this message]
2022-05-12 7:47 ` Dmitry Selyutin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1z8szsv.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=ghostmansd@gmail.com \
--cc=lkcl@lkcl.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).