From: Dmitry Selyutin <ghostmansd@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>, binutils@sourceware.org
Cc: Luke Kenneth Casson Leighton <lkcl@lkcl.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gas/write: extend fx_pcrel_adjust to 16 bits
Date: Thu, 12 May 2022 10:47:16 +0300 [thread overview]
Message-ID: <CAMqzjetTgDVnJwzpxM7n5g3TYDkZDnm=WZ448uT5NTh1KMK0jQ@mail.gmail.com> (raw)
In-Reply-To: <87y1z8szsv.fsf@igel.home>
On Wed, May 11, 2022 at 9:13 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
> It's probably better to swap the fx_size and fx_pcrel_adjust fields, so
> that fx_pcrel_adjust is aligned on a 16 bit boundary.
Thank you for your suggestion! After thinking about it for a while, I
suggest moving the fx_pcrel_adjust (16 bits) field to the top, then
putting fx_size (8 bits), then the rest.
Also, I'd replace `unsigned fx_unused : 2` with a simple `unsigned :
2`, I think this way we can make it even clearer that these bits are
spare. But perhaps this should go as a separate change.
prev parent reply other threads:[~2022-05-12 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 17:59 Dmitry Selyutin
2022-05-11 18:13 ` Andreas Schwab
2022-05-12 7:47 ` Dmitry Selyutin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMqzjetTgDVnJwzpxM7n5g3TYDkZDnm=WZ448uT5NTh1KMK0jQ@mail.gmail.com' \
--to=ghostmansd@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=lkcl@lkcl.net \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).