From: YunQiang Su <yunqiang.su@cipunited.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>, YunQiang Su <wzssyqa@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH v2] GAS/MIPS: Fix testcase module-defer-warn2 for r2+ triples
Date: Fri, 29 Sep 2023 22:23:15 +0800 [thread overview]
Message-ID: <8aee9403-c552-3a42-5be3-1daa1fddea22@cipunited.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2309291514570.18635@angie.orcam.me.uk>
在 2023/9/29 22:18, Maciej W. Rozycki 写道:
> On Fri, 29 Sep 2023, YunQiang Su wrote:
>
>>> As I told you with v1:
>>>
>>>> It seems to me that the best course of action will be converting the test
>>>> to the .d format first, which gives more control, and then split it into
>>>> two, using #skip/#noskip tags as appropriate to select the right one for
>>>> the respective targets.
>>> -- so it has to be a series of two patches:
>>>
>>> * 1/2 to convert the test case to the .d format (keeping the semantics
>>> the same),
>>>
>>> * 2/2 to split it into two, using #skip/#noskip tags.
>>>
>> I will do so.
> As always one self-contained change per patch please. Switching to the
> .d format is one change and fixing R2+ support is another. So it has to
> be two separate changes.
To be make thing more clear, and I am worrying that, the patch can be
spilt to 3 even:
1. switch to .d format
2. add "#skip" tag
3. add new r2 tests.
So, if we'd like to split to 2 patches, should they are {{1,2}, 3} or
{1, {2, 3}}, or should we
split it to 3 ones?
> Maciej
next prev parent reply other threads:[~2023-09-29 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 4:32 [PATCH] " YunQiang Su
2023-08-29 14:46 ` Maciej W. Rozycki
2023-09-26 11:20 ` [PATCH v2] " YunQiang Su
2023-09-28 23:46 ` Maciej W. Rozycki
2023-09-29 13:41 ` YunQiang Su
2023-09-29 14:18 ` Maciej W. Rozycki
2023-09-29 14:23 ` YunQiang Su [this message]
2023-09-29 14:32 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aee9403-c552-3a42-5be3-1daa1fddea22@cipunited.com \
--to=yunqiang.su@cipunited.com \
--cc=binutils@sourceware.org \
--cc=macro@orcam.me.uk \
--cc=wzssyqa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).