From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: YunQiang Su <yunqiang.su@cipunited.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] GAS/MIPS: Fix testcase module-defer-warn2 for r2+ triples
Date: Tue, 29 Aug 2023 15:46:09 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2308291533200.43104@angie.orcam.me.uk> (raw)
In-Reply-To: <20230828043243.2243555-1-yunqiang.su@cipunited.com>
On Mon, 28 Aug 2023, YunQiang Su wrote:
> When gas is configured with --target=mipsisa32r2el-elf, module-defer-warn2
> will fail:
>
> /binutils-gdb/gas/testsuite/gas/mips/module-defer-warn2.s: Assembler messages:
> /binutils-gdb/gas/testsuite/gas/mips/module-defer-warn2.s:2: Error: `gp=64' used with a 32-bit processor
> extra regexps in /binutils-gdb/gas/testsuite/gas/mips/module-defer-warn2.l starting with "^.*:2: .*: `fp=64' used with a 32-bit.*$"
> EOF from dump.out
> FAIL: mips module-defer-warn2
>
> The reason is that fp64 is allowed for mips32r2 and onward, so
> the error message `Error: `fp=64' used with a 32-bit fpu` won't emit.
It has to be a set of separate tests then, because the very purpose of
the test is to verify all the error messages required are there. Making
any optional will defeat the purpose of the test and weaken coverage.
It seems to me that the best course of action will be converting the test
to the .d format first, which gives more control, and then split it into
two, using #skip/#noskip tags as appropriate to select the right one for
the respective targets.
Maciej
next prev parent reply other threads:[~2023-08-29 14:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 4:32 YunQiang Su
2023-08-29 14:46 ` Maciej W. Rozycki [this message]
2023-09-26 11:20 ` [PATCH v2] " YunQiang Su
2023-09-28 23:46 ` Maciej W. Rozycki
2023-09-29 13:41 ` YunQiang Su
2023-09-29 14:18 ` Maciej W. Rozycki
2023-09-29 14:23 ` YunQiang Su
2023-09-29 14:32 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2308291533200.43104@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=binutils@sourceware.org \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).