From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: YunQiang Su <wzssyqa@gmail.com>
Cc: YunQiang Su <yunqiang.su@cipunited.com>, binutils@sourceware.org
Subject: Re: [PATCH v2] GAS/MIPS: Fix testcase module-defer-warn2 for r2+ triples
Date: Fri, 29 Sep 2023 15:18:31 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2309291514570.18635@angie.orcam.me.uk> (raw)
In-Reply-To: <CAKcpw6WsqzRNkrdEF6oFr1YT9rjssg=CagJiDfGi_PcsSMu-mw@mail.gmail.com>
On Fri, 29 Sep 2023, YunQiang Su wrote:
> > As I told you with v1:
> >
> > > It seems to me that the best course of action will be converting the test
> > > to the .d format first, which gives more control, and then split it into
> > > two, using #skip/#noskip tags as appropriate to select the right one for
> > > the respective targets.
> >
> > -- so it has to be a series of two patches:
> >
> > * 1/2 to convert the test case to the .d format (keeping the semantics
> > the same),
> >
> > * 2/2 to split it into two, using #skip/#noskip tags.
> >
>
> I will do so.
As always one self-contained change per patch please. Switching to the
.d format is one change and fixing R2+ support is another. So it has to
be two separate changes.
Maciej
next prev parent reply other threads:[~2023-09-29 14:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 4:32 [PATCH] " YunQiang Su
2023-08-29 14:46 ` Maciej W. Rozycki
2023-09-26 11:20 ` [PATCH v2] " YunQiang Su
2023-09-28 23:46 ` Maciej W. Rozycki
2023-09-29 13:41 ` YunQiang Su
2023-09-29 14:18 ` Maciej W. Rozycki [this message]
2023-09-29 14:23 ` YunQiang Su
2023-09-29 14:32 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2309291514570.18635@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=binutils@sourceware.org \
--cc=wzssyqa@gmail.com \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).