New AArch64 GAS testsuite failure for CSSC

New AArch64 GAS testsuite failure for CSSC

[Nick Clifton]

Hi Andre,

   I am seeing a new testsuite failure in the GAS testsuite for AArch64
   targets.  There appear to be two problems.  For a toolchain configured
   as aarch64-linux-gnu it seems that the regexps do not match.  (There
   appears to be some extra text in gas/testsuite/gas/aarch64/cssc.d that
   is not present in the disassembler output).

   Secondly, for a toolchain configured as aarch64_be-linux-gnu the test
   source file does not assemble at all. :-(

   Please could you fix these problems ?

Cheers
   Nick

Re: New AArch64 GAS testsuite failure for CSSC

[Andre Vieira (lists)]

Yeah, sorry about that.  I'll have a look.

Kind regards,
Andre

On 15/11/2022 10:42, Nick Clifton wrote:
> Hi Andre,
>
>   I am seeing a new testsuite failure in the GAS testsuite for AArch64
>   targets.  There appear to be two problems.  For a toolchain configured
>   as aarch64-linux-gnu it seems that the regexps do not match. (There
>   appears to be some extra text in gas/testsuite/gas/aarch64/cssc.d that
>   is not present in the disassembler output).
>
>   Secondly, for a toolchain configured as aarch64_be-linux-gnu the test
>   source file does not assemble at all. :-(
>
>   Please could you fix these problems ?
>
> Cheers
>   Nick
>

Re: New AArch64 GAS testsuite failure for CSSC

[Andre Vieira (lists)]

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

Hi Nick,

I committed attached patch as obvious to fix the first issue and I was 
about to say I couldn't reproduce the big endian failure, but I just 
noticed I was building a aarch64_be-none-elf. I'll go have a look at 
aarch64_be-linux-gnu now...

Kind regards,
Andre

On 15/11/2022 10:42, Nick Clifton wrote:
> Hi Andre,
>
>   I am seeing a new testsuite failure in the GAS testsuite for AArch64
>   targets.  There appear to be two problems.  For a toolchain configured
>   as aarch64-linux-gnu it seems that the regexps do not match. (There
>   appears to be some extra text in gas/testsuite/gas/aarch64/cssc.d that
>   is not present in the disassembler output).
>
>   Secondly, for a toolchain configured as aarch64_be-linux-gnu the test
>   source file does not assemble at all. :-(
>
>   Please could you fix these problems ?
>
> Cheers
>   Nick
>

[-- Attachment #2: cssc_testsuite_fix.patch --]
[-- Type: text/plain, Size: 510 bytes --]

diff --git a/gas/testsuite/gas/aarch64/cssc.d b/gas/testsuite/gas/aarch64/cssc.d
index 4741b6584f658b0cd2dfa5f9256f94e4d14455c6..d41df24b916d26b0c71ad0435f3e83090268e4e7 100644
--- a/gas/testsuite/gas/aarch64/cssc.d
+++ b/gas/testsuite/gas/aarch64/cssc.d
@@ -7,13 +7,6 @@
 Disassembly of section \.text:
 
 0+ <.*>:
-
-a.out:     file format elf64-littleaarch64
-
-
-Disassembly of section .text:
-
-0000000000000000 <.text>:
    0:	5ac02000 	abs	w0, w0
    4:	5ac02001 	abs	w1, w0
    8:	5ac02100 	abs	w0, w8

Re: New AArch64 GAS testsuite failure for CSSC

[Andre Vieira (lists)]

Nope... can't reproduce on aarch64_be-linux-gnu either. Could you check 
again? How exactly are you configuring your toolchain? I used 'configure 
--disable-sim --disable-gdb --target=aarch64_be-linux-gnu' and was built 
in an aarch64-linux-gnu host.

Kind regards,
Andre

On 15/11/2022 14:43, Andre Vieira (lists) via Binutils wrote:
> Hi Nick,
>
> I committed attached patch as obvious to fix the first issue and I was 
> about to say I couldn't reproduce the big endian failure, but I just 
> noticed I was building a aarch64_be-none-elf. I'll go have a look at 
> aarch64_be-linux-gnu now...
>
> Kind regards,
> Andre
>
> On 15/11/2022 10:42, Nick Clifton wrote:
>> Hi Andre,
>>
>>   I am seeing a new testsuite failure in the GAS testsuite for AArch64
>>   targets.  There appear to be two problems.  For a toolchain configured
>>   as aarch64-linux-gnu it seems that the regexps do not match. (There
>>   appears to be some extra text in gas/testsuite/gas/aarch64/cssc.d that
>>   is not present in the disassembler output).
>>
>>   Secondly, for a toolchain configured as aarch64_be-linux-gnu the test
>>   source file does not assemble at all. :-(
>>
>>   Please could you fix these problems ?
>>
>> Cheers
>>   Nick
>>

Re: New AArch64 GAS testsuite failure for CSSC

[Nick Clifton]

Hi Andre,

> Nope... can't reproduce on aarch64_be-linux-gnu either. Could you check again? How exactly are you configuring your toolchain? I used 'configure --disable-sim --disable-gdb 
> --target=aarch64_be-linux-gnu' and was built in an aarch64-linux-gnu host.

*sigh*  I cannot reproduce it either now. I must have had something
mis-configured. :-(

Anyway - the tests are all passing now, so thank you very much for
fixing the testcase.

Cheers
   Nick