* Re: oss-fuzz: binutils: Fuzzing build failure [not found] ` <E183C216-573D-46D3-AA24-371315273B70@catenacyber.fr> @ 2020-09-21 9:16 ` Alan Modra 2020-09-21 11:53 ` Philippe Antoine 0 siblings, 1 reply; 2+ messages in thread From: Alan Modra @ 2020-09-21 9:16 UTC (permalink / raw) To: Philippe Antoine; +Cc: binutils On Fri, Sep 18, 2020 at 09:14:42PM +0200, Philippe Antoine wrote: > Latest clang introduced a new warning again. > And it found a bug in binutils, preventing the oss-fuzz build Thanks, I committed a variation on your patch, trimming off trailing commas too. * rx-dis.c (flag_names): Add missing comma. (register_names, flag_names, double_register_names), (double_register_high_names, double_register_low_names), (double_control_register_names, double_condition_names): Remove trailing commas. diff --git a/opcodes/rx-dis.c b/opcodes/rx-dis.c index 29ba71c121..1e5591ca98 100644 --- a/opcodes/rx-dis.c +++ b/opcodes/rx-dis.c @@ -85,7 +85,7 @@ static char const * register_names[] = "psw", "pc", "usp", "fpsw", NULL, NULL, NULL, NULL, "bpsw", "bpc", "isp", "fintv", "intb", "extb", NULL, NULL, "a0", "a1", NULL, NULL, NULL, NULL, NULL, NULL, - NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL }; static char const * condition_names[] = @@ -99,36 +99,36 @@ static const char * flag_names[] = { "c", "z", "s", "o", "", "", "", "", "", "", "", "", "", "", "", "", - "i", "u", "", "", "", "", "", "" - "", "", "", "", "", "", "", "", + "i", "u", "", "", "", "", "", "", + "", "", "", "", "", "", "", "" }; static const char * double_register_names[] = { "dr0", "dr1", "dr2", "dr3", "dr4", "dr5", "dr6", "dr7", - "dr8", "dr9", "dr10", "dr11", "dr12", "dr13", "dr14", "dr15", + "dr8", "dr9", "dr10", "dr11", "dr12", "dr13", "dr14", "dr15" }; static const char * double_register_high_names[] = { "drh0", "drh1", "drh2", "drh3", "drh4", "drh5", "drh6", "drh7", - "drh8", "drh9", "drh10", "drh11", "drh12", "drh13", "drh14", "drh15", + "drh8", "drh9", "drh10", "drh11", "drh12", "drh13", "drh14", "drh15" }; static const char * double_register_low_names[] = { "drl0", "drl1", "drl2", "drl3", "drl4", "drl5", "drl6", "drl7", - "drl8", "drl9", "drl10", "drl11", "drl12", "drl13", "drl14", "drl15", + "drl8", "drl9", "drl10", "drl11", "drl12", "drl13", "drl14", "drl15" }; static const char * double_control_register_names[] = { - "dpsw", "dcmr", "decnt", "depc", + "dpsw", "dcmr", "decnt", "depc" }; static const char * double_condition_names[] = { - "", "un", "eq", "", "lt", "", "le", + "", "un", "eq", "", "lt", "", "le" }; static inline const char * -- Alan Modra Australia Development Lab, IBM ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: oss-fuzz: binutils: Fuzzing build failure 2020-09-21 9:16 ` oss-fuzz: binutils: Fuzzing build failure Alan Modra @ 2020-09-21 11:53 ` Philippe Antoine 0 siblings, 0 replies; 2+ messages in thread From: Philippe Antoine @ 2020-09-21 11:53 UTC (permalink / raw) To: Alan Modra; +Cc: binutils [-- Attachment #1: Type: text/plain, Size: 2699 bytes --] Thanks Alan > Le 21 sept. 2020 à 11:16, Alan Modra <amodra@gmail.com> a écrit : > > On Fri, Sep 18, 2020 at 09:14:42PM +0200, Philippe Antoine wrote: >> Latest clang introduced a new warning again. >> And it found a bug in binutils, preventing the oss-fuzz build > > Thanks, I committed a variation on your patch, trimming off trailing > commas too. > > * rx-dis.c (flag_names): Add missing comma. > (register_names, flag_names, double_register_names), > (double_register_high_names, double_register_low_names), > (double_control_register_names, double_condition_names): Remove > trailing commas. > > diff --git a/opcodes/rx-dis.c b/opcodes/rx-dis.c > index 29ba71c121..1e5591ca98 100644 > --- a/opcodes/rx-dis.c > +++ b/opcodes/rx-dis.c > @@ -85,7 +85,7 @@ static char const * register_names[] = > "psw", "pc", "usp", "fpsw", NULL, NULL, NULL, NULL, > "bpsw", "bpc", "isp", "fintv", "intb", "extb", NULL, NULL, > "a0", "a1", NULL, NULL, NULL, NULL, NULL, NULL, > - NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, > + NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL > }; > > static char const * condition_names[] = > @@ -99,36 +99,36 @@ static const char * flag_names[] = > { > "c", "z", "s", "o", "", "", "", "", > "", "", "", "", "", "", "", "", > - "i", "u", "", "", "", "", "", "" > - "", "", "", "", "", "", "", "", > + "i", "u", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "" > }; > > static const char * double_register_names[] = > { > "dr0", "dr1", "dr2", "dr3", "dr4", "dr5", "dr6", "dr7", > - "dr8", "dr9", "dr10", "dr11", "dr12", "dr13", "dr14", "dr15", > + "dr8", "dr9", "dr10", "dr11", "dr12", "dr13", "dr14", "dr15" > }; > > static const char * double_register_high_names[] = > { > "drh0", "drh1", "drh2", "drh3", "drh4", "drh5", "drh6", "drh7", > - "drh8", "drh9", "drh10", "drh11", "drh12", "drh13", "drh14", "drh15", > + "drh8", "drh9", "drh10", "drh11", "drh12", "drh13", "drh14", "drh15" > }; > > static const char * double_register_low_names[] = > { > "drl0", "drl1", "drl2", "drl3", "drl4", "drl5", "drl6", "drl7", > - "drl8", "drl9", "drl10", "drl11", "drl12", "drl13", "drl14", "drl15", > + "drl8", "drl9", "drl10", "drl11", "drl12", "drl13", "drl14", "drl15" > }; > > static const char * double_control_register_names[] = > { > - "dpsw", "dcmr", "decnt", "depc", > + "dpsw", "dcmr", "decnt", "depc" > }; > > static const char * double_condition_names[] = > { > - "", "un", "eq", "", "lt", "", "le", > + "", "un", "eq", "", "lt", "", "le" > }; > > static inline const char * > > > -- > Alan Modra > Australia Development Lab, IBM [-- Attachment #2: smime.p7s --] [-- Type: application/pkcs7-signature, Size: 2740 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-21 11:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <0=1d79688ba06d41b624f807a991e6c9ee=59d48433e0764783d31f65a1dd0c2b85=oss-fuzz@monorail-prod.appspotmail.com>
[not found] ` <0000000000001f161f0598158d92@google.com>
[not found] ` <F580BE4E-75A4-493D-A5C1-DEE6E68071F3@catenacyber.fr>
[not found] ` <411708c7-7c97-9a48-c072-1f1c1109c3c7@redhat.com>
[not found] ` <0FBB84B3-27CB-4884-8AB5-0216EA447A28@catenacyber.fr>
[not found] ` <ce754fc9-edcc-7ca0-9d76-ae16fece10f3@redhat.com>
[not found] ` <E183C216-573D-46D3-AA24-371315273B70@catenacyber.fr>
2020-09-21 9:16 ` oss-fuzz: binutils: Fuzzing build failure Alan Modra
2020-09-21 11:53 ` Philippe Antoine
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).