public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@gmail.com>
To: Nelson Chu <nelson@rivosinc.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	jeffreyalaw@gmail.com, christoph.muellner@vrull.eu,
	 binutils@sourceware.org, Andrew Waterman <andrew@sifive.com>,
	 Jim Wilson <jim.wilson.gcc@gmail.com>,
	philipp.tomsich@vrull.eu, jbeulich@suse.com,
	 research_trasio@irq.a4lg.com
Subject: Re: [RFC PATCH v5] RISC-V: Add support for the Zfa extension
Date: Fri, 30 Jun 2023 14:49:28 +0800	[thread overview]
Message-ID: <CA+yXCZDraUcLj8VkqumMkdUWBvytqVxDHfVTGjDUbJtoRVUTBA@mail.gmail.com> (raw)
In-Reply-To: <CAPpQWtCmpFOzEFWvBU+AS2R_nxN9Oq=L6OGK854F8ZHkZbKpDw@mail.gmail.com>

Hi Nelson:

> > Presumably someone's actually looked at the code?  If not I can look
> > over it...
> >
>
> I have looked and replied, Kito and Jan should also have looked.  The
> special zfa syntax should be the same as LLVM when I looked.  But since
> that is almost two month ago, it's good if someone helps to review it again
> to make sure everything is on the line.

The syntax part matches
https://github.com/riscv-non-isa/riscv-asm-manual/pull/85, which also
matches LLVM implementation.

I am happy to see no syntax divergence on both sides :)

So give my blessing, this patch LGTM.

  reply	other threads:[~2023-06-30  6:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13 13:36 Christoph Muellner
2023-06-29  7:52 ` Christoph Müllner
2023-06-29  8:33   ` Christoph Müllner
2023-06-29 15:07   ` Jeff Law
2023-06-29 15:10     ` Christoph Müllner
2023-06-29 15:37       ` Palmer Dabbelt
2023-06-29 15:49         ` Jeff Law
2023-06-29 15:51           ` Philipp Tomsich
2023-06-30 13:40             ` Jeff Law
2023-06-30 14:06               ` Jeff Law
2023-06-30 14:08                 ` Philipp Tomsich
2023-06-30 14:39                   ` Jeff Law
2023-06-29 15:52           ` Palmer Dabbelt
2023-06-29 16:03             ` Jeff Law
2023-06-29 16:12               ` Palmer Dabbelt
2023-06-30 14:07                 ` Philipp Tomsich
2023-06-30  0:47             ` Nelson Chu
2023-06-30  6:49               ` Kito Cheng [this message]
2023-06-30 13:38               ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+yXCZDraUcLj8VkqumMkdUWBvytqVxDHfVTGjDUbJtoRVUTBA@mail.gmail.com \
    --to=kito.cheng@gmail.com \
    --cc=andrew@sifive.com \
    --cc=binutils@sourceware.org \
    --cc=christoph.muellner@vrull.eu \
    --cc=jbeulich@suse.com \
    --cc=jeffreyalaw@gmail.com \
    --cc=jim.wilson.gcc@gmail.com \
    --cc=nelson@rivosinc.com \
    --cc=palmer@dabbelt.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=research_trasio@irq.a4lg.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).