Re: [PATCH] riscv: Add AIA extension support (Smaia, Ssaia)

["Christoph Müllner" <christoph.muellner@vrull.eu>]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

On Fri, Aug 26, 2022 at 11:53 AM Nelson Chu <nelson@rivosinc.com> wrote:

> On Fri, Aug 26, 2022 at 3:11 AM Christoph Müllner
> <christoph.muellner@vrull.eu> wrote:
> >
> > This patch needs a v2 anyway because I missed the Hypervisor and VS CSRs.
>
> Yeah, reviewed in advance, except the missing Hypervisor AIA CSRs and
> the spec frozen issue which mentioned by Palmer, otherwise LGTM.  Just
> curious that will we add something like "Shaia" or "Zhaia" for the
> Hypervisor and VS AIA CSRs?  If no, then seems like they will belong
> to the single h extension directly?  Anyway, this patch just support
> Ssaia and Smaia extensions, so missing the hypervisor and VS AIA CSRs
> seems reasonable...  Anyway, all of us agree to wait for the AIA spec
> frozen before merging, so I think you can just merge this after that
> time, since the Ssaia and Smaia don't include the Hypervisor AIA in
> fact...
>

AIA spec is now frozen for a few weeks.
Therefore I've sent a v2, that includes the hypervisor and VS CSRs.

See:
  https://sourceware.org/pipermail/binutils/2022-November/124466.html


>
> > > >> @@ -947,7 +956,12 @@ riscv_csr_address (const char *csr_name,
> > > >>                       || csr_class == CSR_CLASS_SMSTATEEN_AND_H_32);
> > > >>        extension = "smstateen";
> > > >>        break;
> > > >> -    case CSR_CLASS_SSCOFPMF_32:
> > > >> +    case CSR_CLASS_SSAIA:
> > > >> +    case CSR_CLASS_SSAIA_32:
> > > >> +      is_rv32_only = (csr_class == CSR_CLASS_SSAIA_32);
> > > >> +      extension = "ssaia";
> > > >> +      break;
> > > >> +     case CSR_CLASS_SSCOFPMF_32:
>
> Here should be a minor indent issue.
>

Fixed in v2 as well.


>
> Thanks
> Nelson
>