From: Nelson Chu <nelson@rivosinc.com>
To: "Christoph Müllner" <christoph.muellner@vrull.eu>
Cc: binutils@sourceware.org, Andrew Waterman <andrew@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>
Subject: Re: [PATCH] riscv: Add AIA extension support (Smaia, Ssaia)
Date: Fri, 18 Nov 2022 17:34:06 +0800 [thread overview]
Message-ID: <CAPpQWtDonOMBxXBoKoRAEbP_HPLENwUd_cqtLiZceo2Va1rFNw@mail.gmail.com> (raw)
In-Reply-To: <CAEg0e7gJ4K6Kbd0CXycMernGiWH5oBoqF4Zwe+bO-Yzc8KO07w@mail.gmail.com>
On Fri, Nov 18, 2022 at 5:08 PM Christoph Müllner
<christoph.muellner@vrull.eu> wrote:
>
>
>
> On Fri, Nov 18, 2022 at 9:12 AM Nelson Chu <nelson@rivosinc.com> wrote:
>>
>> > +DECLARE_CSR(hvien, CSR_HVIEN, CSR_CLASS_SMAIA_AND_H, PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE)
>> > +DECLARE_CSR(hvictl, CSR_HVICTL, CSR_CLASS_SMAIA_AND_H, PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE)
>> > +DECLARE_CSR(hviprio1, CSR_HVIPRIO1, CSR_CLASS_SMAIA_AND_H, PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE)
>> > +DECLARE_CSR(hviprio2, CSR_HVIPRIO2, CSR_CLASS_SMAIA_AND_H, PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE)
>> > +DECLARE_CSR(hidelegh, CSR_HIDELEGH, CSR_CLASS_SMAIA_AND_H_32, PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE)
>> > +DECLARE_CSR(hvienh, CSR_HVIENH, CSR_CLASS_SMAIA_AND_H_32, PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE)
>> > +DECLARE_CSR(hviph, CSR_HVIPH, CSR_CLASS_SMAIA_AND_H_32, PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE)
>> > +DECLARE_CSR(hviprio1h, CSR_HVIPRIO1H, CSR_CLASS_SMAIA_AND_H_32, PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE)
>> > +DECLARE_CSR(hviprio2h, CSR_HVIPRIO2H, CSR_CLASS_SMAIA_AND_H_32, PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE)
>>
>> Just curious does the spec clarify these belonged to smaia? or should
>> these just belonged to h?
>
>
> The AIA spec says:
> "If a hart implements the Privileged Architecture’s hypervisor extension, then the hypervisor and
> VS CSRs listed in Table 2.3 are also added"
>
> So I think the way it is modeled is correct.
So if we only enable ssaia and h, then we can only use virtual
supervisor aia CSRs, but cannot use the hypervisor aia? If that true,
then looks good.
Thanks
Nelson
next prev parent reply other threads:[~2022-11-18 9:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 0:32 Christoph Muellner
2022-11-18 5:07 ` Tsukasa OI
2022-11-18 8:33 ` Christoph Müllner
2022-11-18 8:44 ` Tsukasa OI
2022-11-18 9:11 ` Christoph Müllner
2022-11-18 8:12 ` Nelson Chu
2022-11-18 9:08 ` Christoph Müllner
2022-11-18 9:34 ` Nelson Chu [this message]
2022-11-22 9:51 ` Christoph Müllner
2022-11-19 5:59 ` Tsukasa OI
-- strict thread matches above, loose matches on Subject: below --
2022-08-25 14:54 Christoph Muellner
2022-08-25 14:54 ` Christoph Muellner
2022-08-25 15:16 ` Christoph Müllner
2022-08-25 18:05 ` Palmer Dabbelt
2022-08-25 19:11 ` Christoph Müllner
2022-08-25 20:49 ` Palmer Dabbelt
2022-08-25 21:49 ` Philipp Tomsich
2022-08-26 9:53 ` Nelson Chu
2022-11-18 0:35 ` Christoph Müllner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPpQWtDonOMBxXBoKoRAEbP_HPLENwUd_cqtLiZceo2Va1rFNw@mail.gmail.com \
--to=nelson@rivosinc.com \
--cc=andrew@sifive.com \
--cc=binutils@sourceware.org \
--cc=christoph.muellner@vrull.eu \
--cc=jim.wilson.gcc@gmail.com \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).