public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nelson Chu <nelson.chu@sifive.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Tristan Gingold <tgingold@free.fr>, Binutils <binutils@sourceware.org>
Subject: Re: [PATCH 2/2] RISC-V: Fix inconsistent error message (range)
Date: Wed, 22 Jun 2022 18:36:01 +0800	[thread overview]
Message-ID: <CAJYME4Efb8_rMvjXFSrPoKCeCsesoLRifWVbw6mts2HdYT_Xrg@mail.gmail.com> (raw)
In-Reply-To: <0e3c9ab420d8610937845af7a35bacc1672f8a84.1654855051.git.research_trasio@irq.a4lg.com>

LGTM, so committed

Thanks
Nelson

On Fri, Jun 10, 2022 at 6:00 PM Tsukasa OI <research_trasio@irq.a4lg.com> wrote:
>
> This commit fixes inconsistent error message format involving compressed
> funct<n> fields.  In specific, funct6 had an error message with range
> 0..2^<n> ("0..64") unlike other funct<n> fields with 0..2^<n>-1
> (e.g. funct4 with "0..15").
>
> gas/ChangeLog:
>
>         * config/tc-riscv.c (riscv_ip): Fix inconsistent error message.
> ---
>  gas/config/tc-riscv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c
> index 1b730b4be36..a10ae8e237b 100644
> --- a/gas/config/tc-riscv.c
> +++ b/gas/config/tc-riscv.c
> @@ -2582,7 +2582,7 @@ riscv_ip (char *str, struct riscv_cl_insn *ip, expressionS *imm_expr,
>                             || imm_expr->X_add_number >= 64)
>                           {
>                             as_bad (_("bad value for compressed funct6 "
> -                                     "field, value must be 0...64"));
> +                                     "field, value must be 0...63"));
>                             break;
>                           }
>                         INSERT_OPERAND (CFUNCT6, *ip, imm_expr->X_add_number);
> --
> 2.34.1
>

  reply	other threads:[~2022-06-22 10:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 10:00 [PATCH 0/2] gas: Minor strings fix on June 2022 (Mach-O and RISC-V) Tsukasa OI
2022-06-10 10:00 ` [PATCH 1/2] Mach-O: i18n enablement on some error messages Tsukasa OI
2022-06-10 10:00 ` [PATCH 2/2] RISC-V: Fix inconsistent error message (range) Tsukasa OI
2022-06-22 10:36   ` Nelson Chu [this message]
2022-06-12  4:12 ` [PATCH 0/2] gas: Minor strings fix on June 2022 (Mach-O and RISC-V) Tristan Gingold
2022-06-12  9:28   ` Tsukasa OI
2022-07-13  3:23   ` Tsukasa OI
2022-08-07  7:40 ` [RESEND PATCH 0/1] gas: Minor strings fix on June 2022 (Mach-O part) Tsukasa OI
2022-08-07  7:40   ` [RESEND PATCH 1/1] Mach-O: i18n enablement on some error messages Tsukasa OI
2022-08-08 11:42     ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJYME4Efb8_rMvjXFSrPoKCeCsesoLRifWVbw6mts2HdYT_Xrg@mail.gmail.com \
    --to=nelson.chu@sifive.com \
    --cc=binutils@sourceware.org \
    --cc=research_trasio@irq.a4lg.com \
    --cc=tgingold@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).