public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
	Nick Clifton <nickc@redhat.com>, Jan Beulich <jbeulich@suse.com>,
	Tristan Gingold <tgingold@free.fr>
Cc: binutils@sourceware.org
Subject: [RESEND PATCH 0/1] gas: Minor strings fix on June 2022 (Mach-O part)
Date: Sun,  7 Aug 2022 16:40:41 +0900	[thread overview]
Message-ID: <cover.1659858026.git.research_trasio@irq.a4lg.com> (raw)
In-Reply-To: <cover.1654855051.git.research_trasio@irq.a4lg.com>

This is a ping.

Previous:
<https://sourceware.org/pipermail/binutils/2022-June/121211.html>

This patchset contains some minor string improvements I discovered
while I'm investigating/translating GAS.

Original PATCH 2/2 was merged independently so I will resend PATCH 1/2 only.

It seems this is okay to Tristan (Mach-O maintainer) so I request for merge.
<https://sourceware.org/pipermail/binutils/2022-June/121224.html>



PATCH 1 : gas/config/obj-macho.c (i18n enablement)

On collect_16char_name on this file, there's a formatted error message:

> as_bad (_("the %s name '%s' is too long (maximum 16 characters)"),
>            msg, namstart);

collect_16char_name is called by obj_mach_o_get_section_names but
it does not wrap input `msg' parameter.  Quoting from the function:

> if (collect_16char_name (seg, "segment", 1))

> collect_16char_name (sec, "section", 0);

The words "segment" and "section" should be wrapped with _().
This is not a problem on French but it IS on Spanish.  I quote some
Spanish translation from gas/po/es.po:

> #: config/obj-macho.c:119
> #, c-format
> msgid "the %s name '%s' is too long (maximum 16 characters)"
> msgstr "el nombre %s «%s» es demasiado largo (máximo 16 caracteres)"

> #: config/tc-aarch64.c:607 config/tc-arm.c:1072 config/tc-i860.c:1003
> #: config/tc-sparc.c:3440
> msgid "bad segment"
> msgstr "segmento equivocado"

> #: config/tc-alpha.c:4274
> #, c-format
> msgid "unknown section attribute %s"
> msgstr "atributo seccional %s desconocido"

It will have following mappings in French (fr):

    segment  -->  segment
    section  -->  section

On the other hand, it will have following mappings in Spanish (es):

    segment  -->  segmento
    section  -->  seccional

In Japanese (the language I am trying to translate some GAS strings),
it will be visiblly significant:

Sample message in English:
    the section name 'ABC...' is too long (maximum 16 characters)
Possible Japanese translation without this patch:
    section 名 'ABC...' が長すぎます (最大 16 文字)
Possible Japanese translation with this patch:
    セクション名 'ABC...' が長すぎます (最大 16 文字)

In here, an English word "section" stands out too much in otherwise
Japanese message.  If we can translate the word "section" (technically,
transliterate) to "セクション" (Hepburn: sekushon), the whole sentense
gets more natural.

It will have following mappings in Japanese:

    segment  -->  セグメント
    section  -->  セクション

I completely understand that the most of Binutils users understand what
"section" and "segment" is.  However, we usually translate the text containing
"section" and "segment" (or at least make them translatable) and we don't want
messages with mixed languages.

Thanks,
Tsukasa




Tsukasa OI (1):
  Mach-O: i18n enablement on some error messages

 gas/config/obj-macho.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: 9663a947c09f63f75491dd4ad2f38fb448142240
-- 
2.34.1


  parent reply	other threads:[~2022-08-07  7:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 10:00 [PATCH 0/2] gas: Minor strings fix on June 2022 (Mach-O and RISC-V) Tsukasa OI
2022-06-10 10:00 ` [PATCH 1/2] Mach-O: i18n enablement on some error messages Tsukasa OI
2022-06-10 10:00 ` [PATCH 2/2] RISC-V: Fix inconsistent error message (range) Tsukasa OI
2022-06-22 10:36   ` Nelson Chu
2022-06-12  4:12 ` [PATCH 0/2] gas: Minor strings fix on June 2022 (Mach-O and RISC-V) Tristan Gingold
2022-06-12  9:28   ` Tsukasa OI
2022-07-13  3:23   ` Tsukasa OI
2022-08-07  7:40 ` Tsukasa OI [this message]
2022-08-07  7:40   ` [RESEND PATCH 1/1] Mach-O: i18n enablement on some error messages Tsukasa OI
2022-08-08 11:42     ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1659858026.git.research_trasio@irq.a4lg.com \
    --to=research_trasio@irq.a4lg.com \
    --cc=binutils@sourceware.org \
    --cc=jbeulich@suse.com \
    --cc=nickc@redhat.com \
    --cc=tgingold@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).