From: Nelson Chu <nelson.chu@sifive.com>
To: Christoph Muellner <cmuellner@gcc.gnu.org>
Cc: Binutils <binutils@sourceware.org>,
Kito Cheng <kito.cheng@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Palmer Dabbelt <palmer@dabbelt.com>,
Tsukasa OI <research_trasio@irq.a4lg.com>,
Christoph Muellner <christoph.muellner@vrull.eu>
Subject: Re: [PATCH] RISC-V: Add missing DECLARE_INSNs for Zicbo{m,p,z}
Date: Fri, 22 Apr 2022 10:01:52 +0800 [thread overview]
Message-ID: <CAJYME4F2Km=F42iLCMrREYJekVZwH-TYApoVdd54pUiDFLRnCg@mail.gmail.com> (raw)
In-Reply-To: <20220421223127.2083617-1-cmuellner@gcc.gnu.org>
LGTM, committed. Thanks.
Nelson
On Fri, Apr 22, 2022 at 6:31 AM Christoph Muellner
<cmuellner@gcc.gnu.org> wrote:
>
> The recently added support for the Zicbo{m,p,z} extensions did not
> include DECLARE_INSN() declarations for the instructions.
> These declarations are needed by GDB's instruction detection code.
> This patch adds them.
>
> Signed-off-by: Christoph Muellner <cmuellner@gcc.gnu.org>
> ---
> include/opcode/riscv-opc.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/include/opcode/riscv-opc.h b/include/opcode/riscv-opc.h
> index 3eea33a5dae..15e405bc14e 100644
> --- a/include/opcode/riscv-opc.h
> +++ b/include/opcode/riscv-opc.h
> @@ -2720,6 +2720,15 @@ DECLARE_INSN(hsv_b, MATCH_HSV_B, MASK_HSV_B)
> DECLARE_INSN(hsv_h, MATCH_HSV_H, MASK_HSV_H)
> DECLARE_INSN(hsv_w, MATCH_HSV_W, MASK_HSV_W)
> DECLARE_INSN(hsv_d, MATCH_HSV_D, MASK_HSV_D)
> +/* Zicbop instructions. */
> +DECLARE_INSN(prefetch_r, MATCH_PREFETCH_R, MASK_PREFETCH_R);
> +DECLARE_INSN(prefetch_w, MATCH_PREFETCH_W, MASK_PREFETCH_W);
> +DECLARE_INSN(prefetch_i, MATCH_PREFETCH_I, MASK_PREFETCH_I);
> +/* Zicbom/Zicboz instructions. */
> +DECLARE_INSN(cbo_clean, MATCH_CBO_CLEAN, MASK_CBO_CLEAN);
> +DECLARE_INSN(cbo_flush, MATCH_CBO_FLUSH, MASK_CBO_FLUSH);
> +DECLARE_INSN(cbo_inval, MATCH_CBO_INVAL, MASK_CBO_INVAL);
> +DECLARE_INSN(cbo_zero, MATCH_CBO_ZERO, MASK_CBO_ZERO);
> #endif /* DECLARE_INSN */
> #ifdef DECLARE_CSR
> /* Unprivileged Counter/Timers CSRs. */
> --
> 2.35.1
>
prev parent reply other threads:[~2022-04-22 2:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 22:31 Christoph Muellner
2022-04-22 2:01 ` Nelson Chu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJYME4F2Km=F42iLCMrREYJekVZwH-TYApoVdd54pUiDFLRnCg@mail.gmail.com' \
--to=nelson.chu@sifive.com \
--cc=binutils@sourceware.org \
--cc=christoph.muellner@vrull.eu \
--cc=cmuellner@gcc.gnu.org \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
--cc=research_trasio@irq.a4lg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).