* [PATCH] RISC-V: Add missing DECLARE_INSNs for Zicbo{m,p,z}
@ 2022-04-21 22:31 Christoph Muellner
2022-04-22 2:01 ` Nelson Chu
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Muellner @ 2022-04-21 22:31 UTC (permalink / raw)
To: binutils, Nelson Chu, Kito Cheng, Jim Wilson, Philipp Tomsich,
Palmer Dabbelt, Tsukasa OI
Cc: Christoph Muellner, Christoph Muellner
The recently added support for the Zicbo{m,p,z} extensions did not
include DECLARE_INSN() declarations for the instructions.
These declarations are needed by GDB's instruction detection code.
This patch adds them.
Signed-off-by: Christoph Muellner <cmuellner@gcc.gnu.org>
---
include/opcode/riscv-opc.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/include/opcode/riscv-opc.h b/include/opcode/riscv-opc.h
index 3eea33a5dae..15e405bc14e 100644
--- a/include/opcode/riscv-opc.h
+++ b/include/opcode/riscv-opc.h
@@ -2720,6 +2720,15 @@ DECLARE_INSN(hsv_b, MATCH_HSV_B, MASK_HSV_B)
DECLARE_INSN(hsv_h, MATCH_HSV_H, MASK_HSV_H)
DECLARE_INSN(hsv_w, MATCH_HSV_W, MASK_HSV_W)
DECLARE_INSN(hsv_d, MATCH_HSV_D, MASK_HSV_D)
+/* Zicbop instructions. */
+DECLARE_INSN(prefetch_r, MATCH_PREFETCH_R, MASK_PREFETCH_R);
+DECLARE_INSN(prefetch_w, MATCH_PREFETCH_W, MASK_PREFETCH_W);
+DECLARE_INSN(prefetch_i, MATCH_PREFETCH_I, MASK_PREFETCH_I);
+/* Zicbom/Zicboz instructions. */
+DECLARE_INSN(cbo_clean, MATCH_CBO_CLEAN, MASK_CBO_CLEAN);
+DECLARE_INSN(cbo_flush, MATCH_CBO_FLUSH, MASK_CBO_FLUSH);
+DECLARE_INSN(cbo_inval, MATCH_CBO_INVAL, MASK_CBO_INVAL);
+DECLARE_INSN(cbo_zero, MATCH_CBO_ZERO, MASK_CBO_ZERO);
#endif /* DECLARE_INSN */
#ifdef DECLARE_CSR
/* Unprivileged Counter/Timers CSRs. */
--
2.35.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] RISC-V: Add missing DECLARE_INSNs for Zicbo{m,p,z}
2022-04-21 22:31 [PATCH] RISC-V: Add missing DECLARE_INSNs for Zicbo{m,p,z} Christoph Muellner
@ 2022-04-22 2:01 ` Nelson Chu
0 siblings, 0 replies; 2+ messages in thread
From: Nelson Chu @ 2022-04-22 2:01 UTC (permalink / raw)
To: Christoph Muellner
Cc: Binutils, Kito Cheng, Jim Wilson, Philipp Tomsich,
Palmer Dabbelt, Tsukasa OI, Christoph Muellner
LGTM, committed. Thanks.
Nelson
On Fri, Apr 22, 2022 at 6:31 AM Christoph Muellner
<cmuellner@gcc.gnu.org> wrote:
>
> The recently added support for the Zicbo{m,p,z} extensions did not
> include DECLARE_INSN() declarations for the instructions.
> These declarations are needed by GDB's instruction detection code.
> This patch adds them.
>
> Signed-off-by: Christoph Muellner <cmuellner@gcc.gnu.org>
> ---
> include/opcode/riscv-opc.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/include/opcode/riscv-opc.h b/include/opcode/riscv-opc.h
> index 3eea33a5dae..15e405bc14e 100644
> --- a/include/opcode/riscv-opc.h
> +++ b/include/opcode/riscv-opc.h
> @@ -2720,6 +2720,15 @@ DECLARE_INSN(hsv_b, MATCH_HSV_B, MASK_HSV_B)
> DECLARE_INSN(hsv_h, MATCH_HSV_H, MASK_HSV_H)
> DECLARE_INSN(hsv_w, MATCH_HSV_W, MASK_HSV_W)
> DECLARE_INSN(hsv_d, MATCH_HSV_D, MASK_HSV_D)
> +/* Zicbop instructions. */
> +DECLARE_INSN(prefetch_r, MATCH_PREFETCH_R, MASK_PREFETCH_R);
> +DECLARE_INSN(prefetch_w, MATCH_PREFETCH_W, MASK_PREFETCH_W);
> +DECLARE_INSN(prefetch_i, MATCH_PREFETCH_I, MASK_PREFETCH_I);
> +/* Zicbom/Zicboz instructions. */
> +DECLARE_INSN(cbo_clean, MATCH_CBO_CLEAN, MASK_CBO_CLEAN);
> +DECLARE_INSN(cbo_flush, MATCH_CBO_FLUSH, MASK_CBO_FLUSH);
> +DECLARE_INSN(cbo_inval, MATCH_CBO_INVAL, MASK_CBO_INVAL);
> +DECLARE_INSN(cbo_zero, MATCH_CBO_ZERO, MASK_CBO_ZERO);
> #endif /* DECLARE_INSN */
> #ifdef DECLARE_CSR
> /* Unprivileged Counter/Timers CSRs. */
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-22 2:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 22:31 [PATCH] RISC-V: Add missing DECLARE_INSNs for Zicbo{m,p,z} Christoph Muellner
2022-04-22 2:01 ` Nelson Chu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).