Re: [PATCH] elf: Strip unreferenced weak undefined symbols

["H.J. Lu" <hjl.tools@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1453 bytes --]

On Sun, Apr 21, 2024 at 10:50 PM Alexandre Oliva <oliva@gnu.org> wrote:
>
> Thanks again for the patch.
>
> Olivier pointed out that a comment you moved had a duplicate word, and
> suggested removing it.  Ok to install?
>
> From: Olivier Hainque <hainque@adacore.com>
> Date: Mon, 22 Apr 2024 05:30:38 +0000
>
> Remove duplicate word.
>
> for  bfd/ChangeLog
>
>         PR ld/31652
>         * elflink.c (_bfd_elf_link_output_relocs): Drop duplicate word.
> ---
>  bfd/elf-vxworks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bfd/elf-vxworks.c b/bfd/elf-vxworks.c
> index 36e5540f9c04..5d91913f097f 100644
> --- a/bfd/elf-vxworks.c
> +++ b/bfd/elf-vxworks.c
> @@ -186,7 +186,7 @@ elf_vxworks_emit_relocs (bfd *output_bfd,
>                      library.  We are creating a definition in the output
>                      file but it does not come from any of our normal (.o)
>                      files. ie. a PLT stub.  Normally this would be a
> -                    relocation against against SHN_UNDEF with the VMA of
> +                    relocation against SHN_UNDEF with the VMA of
>                      the PLT stub.  This upsets the VxWorks loader.
>                      Convert it to a section-relative relocation.  This
>                      gets some other symbols (for instance .dynbss), but
> --
> 2.25.1
>

I am checking in this as an obvious fix.


-- 
H.J.

[-- Attachment #2: 0001-bfd-Remove-duplicate-word-in-elf-vxworks.c.patch --]
[-- Type: text/x-patch, Size: 1051 bytes --]

From 9b441c415c556e608e22cb9d16b500992a972b0c Mon Sep 17 00:00:00 2001
From: Olivier Hainque <hainque@adacore.com>
Date: Mon, 22 Apr 2024 02:50:28 -0300
Subject: [PATCH] bfd: Remove duplicate word in elf-vxworks.c

	PR ld/31652
	* elf-vxworks.c  (elf_vxworks_emit_relocs): Drop duplicate word.
---
 bfd/elf-vxworks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bfd/elf-vxworks.c b/bfd/elf-vxworks.c
index 36e5540f9c0..5d91913f097 100644
--- a/bfd/elf-vxworks.c
+++ b/bfd/elf-vxworks.c
@@ -186,7 +186,7 @@ elf_vxworks_emit_relocs (bfd *output_bfd,
 		     library.  We are creating a definition in the output
 		     file but it does not come from any of our normal (.o)
 		     files. ie. a PLT stub.  Normally this would be a
-		     relocation against against SHN_UNDEF with the VMA of
+		     relocation against SHN_UNDEF with the VMA of
 		     the PLT stub.  This upsets the VxWorks loader.
 		     Convert it to a section-relative relocation.  This
 		     gets some other symbols (for instance .dynbss), but
-- 
2.44.0