public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alexandre Oliva <oliva@gnu.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org, hainque@adacore.com
Subject: Re: [PATCH] elf: Strip unreferenced weak undefined symbols
Date: Mon, 22 Apr 2024 02:50:28 -0300	[thread overview]
Message-ID: <or1q6yosij.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <20240418122856.190234-1-hjl.tools@gmail.com> (H. J. Lu's message of "Thu, 18 Apr 2024 05:28:56 -0700")

Thanks again for the patch.

Olivier pointed out that a comment you moved had a duplicate word, and
suggested removing it.  Ok to install?

From: Olivier Hainque <hainque@adacore.com>
Date: Mon, 22 Apr 2024 05:30:38 +0000

Remove duplicate word.

for  bfd/ChangeLog

	PR ld/31652
	* elflink.c (_bfd_elf_link_output_relocs): Drop duplicate word.
---
 bfd/elf-vxworks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bfd/elf-vxworks.c b/bfd/elf-vxworks.c
index 36e5540f9c04..5d91913f097f 100644
--- a/bfd/elf-vxworks.c
+++ b/bfd/elf-vxworks.c
@@ -186,7 +186,7 @@ elf_vxworks_emit_relocs (bfd *output_bfd,
 		     library.  We are creating a definition in the output
 		     file but it does not come from any of our normal (.o)
 		     files. ie. a PLT stub.  Normally this would be a
-		     relocation against against SHN_UNDEF with the VMA of
+		     relocation against SHN_UNDEF with the VMA of
 		     the PLT stub.  This upsets the VxWorks loader.
 		     Convert it to a section-relative relocation.  This
 		     gets some other symbols (for instance .dynbss), but
-- 
2.25.1


-- 
Alexandre Oliva, happy hacker                    https://FSFLA.org/blogs/lxo/
   Free Software Activist                           GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice but
very few check the facts.  Think Assange & Stallman.  The empires strike back

  parent reply	other threads:[~2024-04-22  5:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 12:28 H.J. Lu
2024-04-19  0:38 ` Alan Modra
2024-04-19  7:15 ` Alan Modra
2024-04-22  5:50 ` Alexandre Oliva [this message]
2024-04-23 16:13   ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=or1q6yosij.fsf@lxoliva.fsfla.org \
    --to=oliva@gnu.org \
    --cc=binutils@sourceware.org \
    --cc=hainque@adacore.com \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).