From: "H.J. Lu" <hjl.tools@gmail.com>
To: "Cui, Lili" <lili.cui@intel.com>
Cc: Jan Beulich <jbeulich@suse.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: Enable support to Intel Key locker instructions.
Date: Tue, 22 Sep 2020 19:23:31 -0700 [thread overview]
Message-ID: <CAMe9rOpDQxXbvP_c8qD4L=--FehuGLXUk_5mfaKmyC1ecJH0Tw@mail.gmail.com> (raw)
In-Reply-To: <BYAPR11MB303112B55D68B019586B033E9E380@BYAPR11MB3031.namprd11.prod.outlook.com>
On Tue, Sep 22, 2020 at 7:09 PM Cui, Lili <lili.cui@intel.com> wrote:
>
> > On Tue, Sep 22, 2020 at 9:08 AM Jan Beulich <jbeulich@suse.com> wrote:
> > > >> ... in this table you'll notice that MOD_0F38* all go together, and
> > > >> _later_ there's a MOD_VEX_0F38* group. I notice that recent
> > > >> additions (of yours?) also already violate this sorting model - please may
> > I ask for this to corrected as well?
> > > >> The more outliers we have there, the more difficult will it be to
> > > >> maintain this code.
> > > >
> > > > Thank you reviewing my patch. I put MOD_VEX_0F38* together.
> > >
> > > Imo this should be a separate change, not merged into here.
> >
> > Yes, please make a separate patch.
> >
>
> Ok, I will fix it with a separate patch, thanks.
>
> > > >> ... these four need special treatment in output_insn()'s setting of
> > > >> GNU_PROPERTY_X86_FEATURE_2_XMM, due to the lack of explicit
> > RegXMM
> > > >> operands.
> > > >>
> > > > Added it.
> > >
> > > If I was making a change like this, I'm pretty sure H.J. would ask me
> > > to also add test cases for it.
> > >
> >
> > Yes, please add a new testcase. See:
> >
> > commit a7e12755d57879884c523cae1cf009efc9da933c
> > Author: H.J. Lu <hjl.tools@gmail.com>
> > Date: Wed Feb 19 04:54:45 2020 -0800
> >
> > x86: Mark cvtpi2ps and cvtpi2pd as MMX
> >
> > for an example.
> >
> > Thanks.
> >
> > --
> > H.J.
>
> Added it, thanks.
>
> Lili.
OK.
Thanks.
--
H.J.
prev parent reply other threads:[~2020-09-23 2:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 3:25 Cui, Lili
2020-09-21 3:42 ` H.J. Lu
2020-09-21 8:40 ` Cui, Lili
2020-09-21 9:18 ` Jan Beulich
2020-09-22 8:53 ` Cui, Lili
2020-09-22 16:08 ` Jan Beulich
2020-09-22 16:14 ` H.J. Lu
2020-09-23 2:09 ` Cui, Lili
2020-09-23 2:23 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOpDQxXbvP_c8qD4L=--FehuGLXUk_5mfaKmyC1ecJH0Tw@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
--cc=lili.cui@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).