public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: "Cui, Lili" <lili.cui@intel.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: Enable support to Intel Key locker instructions.
Date: Sun, 20 Sep 2020 20:42:51 -0700	[thread overview]
Message-ID: <CAMe9rOq_r2Ni7mS-_AkSdzsqw8=axFfJpfkmx=f48wCiOPeAoA@mail.gmail.com> (raw)
In-Reply-To: <BYAPR11MB30315DC44E4FC7EF759ED82C9E3A0@BYAPR11MB3031.namprd11.prod.outlook.com>

On Sun, Sep 20, 2020 at 8:26 PM Cui, Lili <lili.cui@intel.com> wrote:
>
> Hi all,
>
> This patch is about to enable binutils support for Key Locker,
> Key Locker provides a mechanism to encrypt and decrypt data with an AES key without having access
> to the raw key value by converting AES keys into "handles", more details please refer to
> https://software.intel.com/content/www/us/en/develop/download/intel-key-locker-specification.html
>
> Make check-gas is ok.
>
> Enable support to Intel Key locker instructions.
>
> gas/
>         * config/tc-i386.c (cpu_arch): Add .kl and .wide_kl.
>         (cpu_noarch): Likewise.
>         * doc/c-i386.texi: Document kl and wide_kl.
>         * testsuite/gas/i386/i386.exp: Run keylocker tests.
>         * testsuite/gas/i386/keylocker-intel.d: New test.
>         * testsuite/gas/i386/keylocker.d: Likewise.
>         * testsuite/gas/i386/keylocker.s: Likewise.
>         * testsuite/gas/i386/x86-64-keylocker-intel.d: Likewise.
>         * testsuite/gas/i386/x86-64-keylocker.d: Likewise.
>         * testsuite/gas/i386/x86-64-keylocker.s: Likewise.
>
> opcodes/
>         * i386-dis.c (enum): Add REG_0F38D8_PREFIX_1,
>         MOD_0F38FA_PREFIX_1, MOD_0F38FB_PREFIX_1,
>         MOD_0F38DC_PREFIX_1, MOD_0F38DD_PREFIX_1,
>         MOD_0F38DE_PREFIX_1, MOD_0F38DF_PREFIX_1,
>         PREFIX_0F38D8, PREFIX_0F38FA, PREFIX_0F38FB.
>         (reg_table): New instructions (see prefixes above).
>         (prefix_table): Likewise.
>         (three_byte_table): Likewise.
>         (mod_table): Likewise
>         * i386-gen.c (cpu_flag_init): Add CPU_KL_FLAGS, CPU_WIDE_KL_FLAGS,
>         CPU_ANY_KL_FLAGS and CPU_ANY_WIDE_KL_FLAGS.
>         (cpu_flags): Likewise.
>         (operand_type_init): Likewise.
>         * i386-opc.h (enum): Add CpuKL and CpuWIDE_KL.
>         (i386_cpu_flags): Add cpukl and cpuwide_kl.
>         * i386-opc.tbl: Add KL and WIDE_KL insns.
>         * i386-init.h: Regenerate.
>         * i386-tbl.h: Likewise.

Please add an entry to gas/NEWS:

* Add support for Intel Key Locker instructions.

OK with this change.

Thanks.

-- 
H.J.

  reply	other threads:[~2020-09-21  3:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21  3:25 Cui, Lili
2020-09-21  3:42 ` H.J. Lu [this message]
2020-09-21  8:40   ` Cui, Lili
2020-09-21  9:18 ` Jan Beulich
2020-09-22  8:53   ` Cui, Lili
2020-09-22 16:08     ` Jan Beulich
2020-09-22 16:14       ` H.J. Lu
2020-09-23  2:09         ` Cui, Lili
2020-09-23  2:23           ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMe9rOq_r2Ni7mS-_AkSdzsqw8=axFfJpfkmx=f48wCiOPeAoA@mail.gmail.com' \
    --to=hjl.tools@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=jbeulich@suse.com \
    --cc=lili.cui@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).