public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH 3/6] x86: add another IAMCU testcase
Date: Wed, 18 May 2022 10:46:02 -0700	[thread overview]
Message-ID: <CAMe9rOpvGCD+X2voQ1C53KzX0kOzV+9hEOuchs9KSWSOixzK-w@mail.gmail.com> (raw)
In-Reply-To: <0d4e74f7-1607-1edc-0652-c4ba701edaeb@suse.com>

On Wed, Mar 16, 2022 at 1:46 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> Now that {L,K}1OM support is gone, and with it the brokenness in
> check_cpu_arch_compatible(), put in place a test making sure that only
> extensions can be enabled via .arch for IAMCU, and that the base
> architecture cannot be changed.
>
> --- a/gas/testsuite/gas/i386/iamcu-inval-1.l
> +++ b/gas/testsuite/gas/i386/iamcu-inval-1.l
> @@ -5,10 +5,11 @@
>  .*:8: Error: .*
>  .*:10: Error: .*
>  .*:11: Error: .*
> +.*:13: Error: .*
>  GAS LISTING .*
>
>
> -[      ]*1[    ]+\# Invalid Intel MCU instructions
> +[      ]*1[    ]+\# Invalid Intel MCU instructions / directives
>  [      ]*2[    ]+\.text
>  [      ]*3[    ]+
>  [      ]*4[    ]+fnstsw
> @@ -19,3 +20,5 @@ GAS LISTING .*
>  [      ]*9[    ]+
>  [      ]*10[   ]+movq  %xmm1, \(%eax\)
>  [      ]*11[   ]+movnti        %eax, \(%eax\)
> +[      ]*12[   ]+
> +[      ]*13[   ]+\.arch generic32
> --- a/gas/testsuite/gas/i386/iamcu-inval-1.s
> +++ b/gas/testsuite/gas/i386/iamcu-inval-1.s
> @@ -1,4 +1,4 @@
> -# Invalid Intel MCU instructions
> +# Invalid Intel MCU instructions / directives
>         .text
>
>         fnstsw
> @@ -9,3 +9,5 @@
>
>         movq    %xmm1, (%eax)
>         movnti  %eax, (%eax)
> +
> +       .arch generic32
>

OK.

Thanks.

-- 
H.J.

  reply	other threads:[~2022-05-18 17:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16  8:42 [PATCH 0/6] x86: drop L1OM/K1OM from gas plus associated tidying Jan Beulich
2022-03-16  8:45 ` [PATCH 1/6] x86: assorted IAMCU CPU checking fixes Jan Beulich
2022-03-16  8:46 ` [PATCH 2/6] x86: drop L1OM/K1OM support from gas Jan Beulich
2022-03-16  8:46 ` [PATCH 3/6] x86: add another IAMCU testcase Jan Beulich
2022-05-18 17:46   ` H.J. Lu [this message]
2022-03-16  8:47 ` [PATCH 4/6] x86: unify CPU flag on/off processing Jan Beulich
2022-03-16  8:48 ` [PATCH 5/6] x86: never set i386_cpu_flags' "unused" field Jan Beulich
2022-03-16  8:48 ` [PATCH 6/6] x86: don't accept base architectures as extensions Jan Beulich
2022-03-16 17:11 ` [PATCH 0/6] x86: drop L1OM/K1OM from gas plus associated tidying H.J. Lu
2022-03-17  8:32   ` Jan Beulich
2022-03-17 15:11     ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMe9rOpvGCD+X2voQ1C53KzX0kOzV+9hEOuchs9KSWSOixzK-w@mail.gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=jbeulich@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).