From: "H.J. Lu" <hjl.tools@gmail.com>
To: "Cui, Lili" <lili.cui@intel.com>
Cc: "Beulich, Jan" <JBeulich@suse.com>,
"binutils@sourceware.org" <binutils@sourceware.org>,
"Lu, Hongjiu" <hongjiu.lu@intel.com>
Subject: Re: [PATCH] Support APX NF
Date: Thu, 29 Feb 2024 04:23:18 -0800 [thread overview]
Message-ID: <CAMe9rOq-2u=9=zDvKsmZ+8NGVNHmT2Xudu+Lyid4v1xCS-dkuw@mail.gmail.com> (raw)
In-Reply-To: <SJ0PR11MB5600B1A787BE9B48B9379E819E5F2@SJ0PR11MB5600.namprd11.prod.outlook.com>
On Thu, Feb 29, 2024 at 2:22 AM Cui, Lili <lili.cui@intel.com> wrote:
>
> > On 29.02.2024 09:39, Cui, Lili wrote:
> > >> On 28.02.2024 17:11, H.J. Lu wrote:
> > >>> On Tue, Feb 27, 2024 at 1:02 AM Cui, Lili <lili.cui@intel.com> wrote:
> > >>>>
> > >>>> gas/ChangeLog:
> > >>>>
> > >>>> * config/tc-i386.c (enum i386_error): Add unsupported_nf.
> > >>>> (struct _i386_insn): Add has_nf.
> > >>>> (need_evex_encoding): Ditto.
> > >>>> (is_apx_evex_encoding): Ditto.
> > >>>> (build_apx_evex_prefix): Encode the NF bit.
> > >>>> (md_assemble): Handle unsupported_nf.
> > >>>> (parse_insn): Handle Prefix_NF.
> > >>>> (match_template): Check NF support.
> > >>>> * testsuite/gas/i386/x86-64.exp: Add apx nf tests.
> > >>>> * testsuite/gas/i386/x86-64-apx-nf-intel.d: New test.
> > >>>> * testsuite/gas/i386/x86-64-apx-nf.d: Ditto.
> > >>>> * testsuite/gas/i386/x86-64-apx-nf.s: Ditto.
> > >>>>
> > >>>> opcodes/ChangeLog:
> > >>>>
> > >>>> * i386-dis-evex.h: Add %XN to the instructions that support
> > >>>> APX NF
> > >> and
> > >>>> add new instruction imul, popcnt, tzcnt and lzcnt to EVEX table.
> > >>>> * i386-dis-evex-reg.h: Ditto.
> > >>>> * i386-dis.c (struct instr_info): Add nf.
> > >>>> (struct dis386): Add "XN" for EVEX.NF.
> > >>>> (get_valid_dis386): Set ins->vex.nf.
> > >>>> (print_insn): Handle ins.vex.nf.
> > >>>> (putop): Handle "%XN".
> > >>>> * i386-opc.h (Prefix_NoOptimize): Adjust the value.
> > >>>> (Prefix_NF): New.
> > >>>> * i386-opc.tbl: Add new entries for the instructions that
> > >>>> support APX
> > >> NF.
> > >>>> * i386-mnem.h: Regenerated.
> > >>>> * i386-tbl.h: Regenerated.
> > >>>>
> > >>>
> > >>> Please mention it in gas/NEWS.
> > >>
> > >> Hmm. I think it wants mentioning once APX support is actually complete.
> > >> I don't think every sub-feature of it needs mentioning.
> > >>
> > >
> > > Thanks Jan, since this place is easy to forget, I can create an initial one, and
> > each sub-feature can be appended one by one after the NF, only one mention
> > is left at the end.
> > >
> > > --- a/gas/NEWS
> > > +++ b/gas/NEWS
> > > @@ -1,5 +1,7 @@
> > > -*- text -*-
> > >
> > > +* Initial support for Intel APX: NF
It isn't initial support for Intel APX. Please use something like
Support the NF feature in Intel APX.
> > > +
> >
> > Personally I consider this confusing; imo APX shouldn't have been mentioned
> > in 2.42's gas/NEWS at all. Yet if you and H.J. firmly think that's the way to go,
> > so be it.
> >
>
> For APX NF, it will be placed after 2.42 and belong to 2.43. Since we didn't implement the entire APX in 2.42, we list the APX sub-feature that it has implemented.
>
> Changes in 2.42:
> ...
> * Initial support for Intel APX: 32 GPRs, NDD, PUSH2/POP2 and PUSHP/POPP.
>
> Thanks,
> Lili.
--
H.J.
next prev parent reply other threads:[~2024-02-29 12:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 9:01 Cui, Lili
2024-02-28 16:11 ` H.J. Lu
2024-02-29 1:12 ` Cui, Lili
2024-02-29 6:53 ` Jan Beulich
2024-02-29 8:39 ` Cui, Lili
2024-02-29 9:06 ` Jan Beulich
2024-02-29 10:22 ` Cui, Lili
2024-02-29 12:23 ` H.J. Lu [this message]
2024-02-29 12:26 ` Cui, Lili
2024-02-29 11:21 ` Jan Beulich
2024-02-29 12:00 ` Cui, Lili
2024-02-29 12:04 ` Jan Beulich
2024-02-29 12:41 ` Cui, Lili
2024-02-29 13:17 ` Jan Beulich
2024-02-29 13:47 ` Cui, Lili
2024-02-29 14:12 ` Jan Beulich
2024-03-01 3:23 ` Cui, Lili
2024-03-01 6:56 ` Jan Beulich
2024-03-01 8:01 ` Cui, Lili
2024-03-01 11:36 ` Cui, Lili
2024-03-01 11:49 ` Jan Beulich
2024-03-01 7:04 ` Jan Beulich
2024-03-01 11:50 ` Cui, Lili
2024-03-19 6:41 Cui, Lili
2024-03-21 14:26 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOq-2u=9=zDvKsmZ+8NGVNHmT2Xudu+Lyid4v1xCS-dkuw@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=JBeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hongjiu.lu@intel.com \
--cc=lili.cui@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).