Re: [PATCH v4] ld: Rewrite lang_size_relro_segment_1

["H.J. Lu" <hjl.tools@gmail.com>]

On Wed, Jan 26, 2022 at 4:48 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Wed, Jan 26, 2022 at 10:55:35AM +0000, Nick Clifton via Binutils wrote:
> > Hi H.J.
> >
> > > Here is the v4 patch to align the PT_GNU_RELRO segment first and subtract
> > > the maximum page size if therer is still a 1-page gap.  This fixes:
> > >
> > > https://sourceware.org/bugzilla/show_bug.cgi?id=28819
> >
> > Looks good to me.  Please apply.  Branch and mainline.
>
> How was this patch tested?  If it has not been tested on targets other
> than x86 then it is not appropriate for the branch.  Instead, I

What kinds of tests are you looking for?  Do you have a testcase to show
there is still an issue?

> believe commit 2f83249c13d ought to be reverted on the branch.  A
> wasted page in memory layout is not an important problem.  We have
> more serious relro issues on targets other than x86.  See pr28824.
>
> I'm speaking up because I raised concerns over the design of the
> previous patch, not just the implementation, and had those concerns
> overridden by Nick.  Or possibly Nick didn't see my email before the
> previous patch was approved.  Regardless of how it happened, I fear
> we might have even worse relro support in 2.38.
>
> FWIW, I also think that any fix I might develop for pr28824 will
> likely not be release branch quality until is has been tested for some
> time on mainline.
>
> --
> Alan Modra
> Australia Development Lab, IBM



-- 
H.J.