From: Alan Modra <amodra@gmail.com>
To: Nick Clifton <nickc@redhat.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>, Binutils <binutils@sourceware.org>
Subject: Re: [PATCH v4] ld: Rewrite lang_size_relro_segment_1
Date: Thu, 27 Jan 2022 11:18:12 +1030 [thread overview]
Message-ID: <YfHrzNsWnwJDZA4w@squeak.grove.modra.org> (raw)
In-Reply-To: <63e7ccbb-a69e-f38e-6e36-778b5fd39ad5@redhat.com>
On Wed, Jan 26, 2022 at 10:55:35AM +0000, Nick Clifton via Binutils wrote:
> Hi H.J.
>
> > Here is the v4 patch to align the PT_GNU_RELRO segment first and subtract
> > the maximum page size if therer is still a 1-page gap. This fixes:
> >
> > https://sourceware.org/bugzilla/show_bug.cgi?id=28819
>
> Looks good to me. Please apply. Branch and mainline.
How was this patch tested? If it has not been tested on targets other
than x86 then it is not appropriate for the branch. Instead, I
believe commit 2f83249c13d ought to be reverted on the branch. A
wasted page in memory layout is not an important problem. We have
more serious relro issues on targets other than x86. See pr28824.
I'm speaking up because I raised concerns over the design of the
previous patch, not just the implementation, and had those concerns
overridden by Nick. Or possibly Nick didn't see my email before the
previous patch was approved. Regardless of how it happened, I fear
we might have even worse relro support in 2.38.
FWIW, I also think that any fix I might develop for pr28824 will
likely not be release branch quality until is has been tested for some
time on mainline.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2022-01-27 0:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 2:12 [PATCH] elf: Remove the 1-page gap before the RELRO segment H.J. Lu
2022-01-11 5:26 ` Fangrui Song
2022-01-13 12:44 ` Nick Clifton
2022-01-13 12:52 ` Alan Modra
2022-01-13 13:19 ` H.J. Lu
2022-01-14 8:12 ` Alan Modra
2022-01-14 9:37 ` Fangrui Song
2022-01-14 14:58 ` H.J. Lu
2022-01-14 21:55 ` [PATCH] ld: Rewrite lang_size_relro_segment_1 H.J. Lu
2022-01-17 4:08 ` Alan Modra
2022-01-18 4:16 ` [PATCH v2] " H.J. Lu
[not found] ` <CAMe9rOpdkYZDigz8r_oPbweLnaCJUjx3-L-v-vp-70c0MGOHQw@mail.gmail.com>
2022-01-24 16:24 ` Fwd: " Nick Clifton
2022-01-24 21:17 ` [PATCH v3] " H.J. Lu
2022-01-25 15:05 ` [PATCH v4] " H.J. Lu
2022-01-26 10:55 ` Nick Clifton
2022-01-27 0:48 ` Alan Modra [this message]
2022-01-27 2:10 ` H.J. Lu
2022-01-29 1:01 ` Alan Modra
2022-01-29 9:06 ` Fangrui Song
2022-01-29 16:45 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfHrzNsWnwJDZA4w@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).