From: Dmitry Selyutin <ghostmansd@gmail.com>
To: binutils@sourceware.org
Cc: Alan Modra <amodra@gmail.com>, Luke Leighton <luke.leighton@gmail.com>
Subject: Are big tests allowed in binutils?
Date: Fri, 17 Jun 2022 08:11:12 +0300 [thread overview]
Message-ID: <CAMqzjesC5j-XrC6TfSD7toZ+5yG6Ks5+c_44HPPMfgKwxf9UsQ@mail.gmail.com> (raw)
Hi folks,
I'm going to submit a series of patches which add a couple of new
instructions available as SVP64 extensions (under -mlibresoc switch).
Since I want to be a good citizen, I also want to introduce tests for
each instruction, basically comparing the expected results for dumps
(aka run_dump_test). However, I'd like to cover various possible
cases, so I generated a test to cover many different operands; this
makes tests quite big. For example, the assembly listing for a new
svremap instruction takes 10240 lines, and etalon dump takes a bit
more lines. So, questions:
1. Is it OK at all to have tests that large? Time-wise they're fast,
I'm mostly concerned about code base size and readers' patience.
2. Will you tolerate it if I post these tests in the mailing list?
These will be a major headache for any reader if integrated into the
patches.
3. If it's OK to post these tests into the mailing lists, is it
allowed to post them as separate patches from the ones which add the
instructions?
My preferred option would be to split each patch into two parts:
1. The patch which adds the instruction itself.
2. The patch which adds the test for this instruction.
However, looking at patches in PowerPC, I see that the tests generally
come along with the implementation in scope of one patch. I'm afraid
this might make patches barely readable.
If needed, I can cut the size of tests; time-wise it's fast, 10420
lines of asm take 0,04s of real time, I'm only concerned about
readability.
I'd like to know your opinion on this. Thank you!
--
Best regards,
Dmitry Selyutin
next reply other threads:[~2022-06-17 5:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 5:11 Dmitry Selyutin [this message]
2022-06-17 6:19 ` Dmitry Selyutin
2022-06-20 10:42 ` Nick Alcock
2022-06-20 11:31 ` lkcl
2022-06-21 13:43 ` Nick Alcock
2022-06-21 17:26 ` lkcl
2022-06-21 17:29 ` Dmitry Selyutin
2022-06-21 19:23 ` lkcl
2022-06-17 9:14 ` Andreas Schwab
2022-06-21 15:32 ` Richard Earnshaw
2022-06-21 16:28 ` Dmitry Selyutin
2022-06-22 6:55 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMqzjesC5j-XrC6TfSD7toZ+5yG6Ks5+c_44HPPMfgKwxf9UsQ@mail.gmail.com \
--to=ghostmansd@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=luke.leighton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).