Re: [PATCH] ld: add --package-metadata

[Luca Boccassi <bluca@debian.org>]

On Sun, 15 May 2022 at 20:21, <luca.boccassi@gmail.com> wrote:
>
> From: Luca Boccassi <bluca@debian.org>
>
> Generate a .note.package FDO package metadata ELF note, following
> the spec: https://systemd.io/COREDUMP_PACKAGE_METADATA/
>
> If the jansson library is available at build time (and not explicitly
> disabled), link ld to it, and use it to validate that the input is
> correct JSON, to avoid writing garbage to the file.
> If no configure option is passed and jansson (or pkg-config) is not
> found, then it is just skipped (with a non-fatal warning). The
> configure option --enable-jansson can be used to explicitly enable it
> (error out when not found) or to explicitly disable it (don't even
> look for it). This allows bootstrappers (or others who are not
> interested) to seamlessly skip it without issues."
> ---
> Now that this spec has shipped for all packages in Fedora 36, it seems
> like a good time to add a specific option for it to the default linker.
> Follows the same pattern of --build-id.
> I've added an optional usage of libjansson to provide additional validation,
> so that it doesn't have to be reimplemented everywhere a thousand times over.
> For bootstrapping purposes the dep is optional and can be skipped, for example
> in Debian/Ubuntu it would be annotated with <!stage1> so that everything
> works out of the box.
>
>  bfd/elf-bfd.h                        |   8 ++
>  bfd/elf.c                            |   6 +-
>  ld/Makefile.am                       |   6 +-
>  ld/configure.ac                      |  35 ++++++++
>  ld/emultempl/elf.em                  |   9 ++
>  ld/ld.texi                           |   7 ++
>  ld/ldelf.c                           | 121 ++++++++++++++++++++++++++-
>  ld/ldelf.h                           |   2 +
>  ld/lexsup.c                          |   2 +
>  ld/testsuite/ld-elf/package-note.exp |  49 +++++++++++
>  ld/testsuite/ld-elf/package-note.rd  |   6 ++
>  11 files changed, 244 insertions(+), 7 deletions(-)
>  create mode 100644 ld/testsuite/ld-elf/package-note.exp
>  create mode 100644 ld/testsuite/ld-elf/package-note.rd

Hi Nick,

Did you have any chance to look at this? Any thoughts? Thanks!

Kind regards,
Luca Boccassi