Re: [PATCH v2] ld: add --package-metadata

[Alan Modra <amodra@gmail.com>]

On Wed, May 25, 2022 at 02:00:08PM +0930, Alan Modra wrote:
> On Tue, May 24, 2022 at 10:15:07PM +0100, luca.boccassi--- via Binutils wrote:
> > v2: fix style issues
> >     fix ASAN issue: note storage is rounded up, but that size
> >     was used to read the json input, which is fixed
> >     add entry to NEWS
> >     add note about json validation to docs
> 
> Looks OK to me
> 
> > +  if (json_length > SIZE_MAX)
> > +    {
> > +      einfo (_("%P: warning: --package-metadata is too long, ignoring\n"));
> > +      return false;
> > +    }
> 
> except for the above dead code.  OK with that removed.

And how having applied your patch locally and tested, please do look
into fixing
FAIL: bootstrap
FAIL: bootstrap with strip
FAIL: bootstrap with -Wl,--traditional-format
FAIL: bootstrap with -Wl,--no-keep-memory
FAIL: bootstrap with -Wl,--relax
FAIL: bootstrap with -Wl,--max-cache-size=-1
seen with #define HAVE_JANSSON 1

The errors are of course all due to undefined references to libjansson
symbols.

-- 
Alan Modra
Australia Development Lab, IBM