From: Luca Boccassi <bluca@debian.org>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH v2] ld: add --package-metadata
Date: Wed, 25 May 2022 14:42:52 +0100 [thread overview]
Message-ID: <9d4400a363f3019cc7e005abf39fb9c770982957.camel@debian.org> (raw)
In-Reply-To: <Yo3Gf1y/utEuhgtt@squeak.grove.modra.org>
[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]
On Wed, 2022-05-25 at 15:32 +0930, Alan Modra wrote:
> On Wed, May 25, 2022 at 02:00:08PM +0930, Alan Modra wrote:
> > On Tue, May 24, 2022 at 10:15:07PM +0100, luca.boccassi--- via Binutils wrote:
> > > v2: fix style issues
> > > fix ASAN issue: note storage is rounded up, but that size
> > > was used to read the json input, which is fixed
> > > add entry to NEWS
> > > add note about json validation to docs
> >
> > Looks OK to me
> >
> > > + if (json_length > SIZE_MAX)
> > > + {
> > > + einfo (_("%P: warning: --package-metadata is too long, ignoring\n"));
> > > + return false;
> > > + }
> >
> > except for the above dead code. OK with that removed.
>
> And how having applied your patch locally and tested, please do look
> into fixing
> FAIL: bootstrap
> FAIL: bootstrap with strip
> FAIL: bootstrap with -Wl,--traditional-format
> FAIL: bootstrap with -Wl,--no-keep-memory
> FAIL: bootstrap with -Wl,--relax
> FAIL: bootstrap with -Wl,--max-cache-size=-1
> seen with #define HAVE_JANSSON 1
>
> The errors are of course all due to undefined references to libjansson
> symbols.
Thanks for the review, I've fixed both issues in v3.
--
Kind regards,
Luca Boccassi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-05-25 13:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-15 19:18 [PATCH] " luca.boccassi
2022-05-16 16:40 ` Fangrui Song
2022-05-17 6:03 ` Florian Weimer
2022-05-17 14:44 ` Luca Boccassi
2022-05-25 6:56 ` Fangrui Song
2022-05-25 7:53 ` Florian Weimer
2022-05-23 11:26 ` Luca Boccassi
2022-05-24 9:34 ` Jose E. Marchesi
2022-05-24 11:26 ` Luca Boccassi
2022-05-24 16:23 ` Nick Clifton
2022-05-24 18:38 ` Luca Boccassi
2022-05-25 8:45 ` Florian Weimer
2022-05-25 13:53 ` Luca Boccassi
2022-05-30 14:08 ` Florian Weimer
2022-05-24 16:28 ` Nick Clifton
2022-05-24 21:15 ` [PATCH v2] " luca.boccassi
2022-05-25 4:30 ` Alan Modra
2022-05-25 6:02 ` Alan Modra
2022-05-25 13:42 ` Luca Boccassi [this message]
2022-05-25 13:41 ` [PATCH v3] " luca.boccassi
2022-05-26 3:55 ` Alan Modra
2022-05-26 10:46 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d4400a363f3019cc7e005abf39fb9c770982957.camel@debian.org \
--to=bluca@debian.org \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).