public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Christophe Lyon <christophe.lyon@linaro.org>
To: Victor Do Nascimento <victor.donascimento@arm.com>
Cc: binutils@sourceware.org, richard.earnshaw@arm.com, nickc@redhat.com
Subject: Re: [PATCH] aarch64: Fix coding style issue in `aarch64-dis.c'
Date: Mon, 22 Apr 2024 14:26:21 +0200	[thread overview]
Message-ID: <CAPS5khYS-Tqrk5c2-UMfLPLpdRBaayLYDRTq=qaOvD0q3axu8A@mail.gmail.com> (raw)
In-Reply-To: <20240422093500.46611-1-victor.donascimento@arm.com>

Hi Victor,

On Mon, 22 Apr 2024 at 11:35, Victor Do Nascimento
<victor.donascimento@arm.com> wrote:
>
> Fix integer value being returned from boolean function, as introduced
> in `aarch64: Remove asserts from operand qualifier decoders [PR31595]'.
> ---
>  opcodes/aarch64-dis.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c
> index b70e6da9eb7..e1c3f557874 100644
> --- a/opcodes/aarch64-dis.c
> +++ b/opcodes/aarch64-dis.c
> @@ -1038,7 +1038,7 @@ aarch64_ext_ft (const aarch64_operand *self ATTRIBUTE_UNUSED,
>         return false;
>        info->qualifier = get_sreg_qualifier_from_value (value);
>        if (info->qualifier == AARCH64_OPND_QLF_ERR)
> -       return 0;
> +       return false;
>      }
>
>    return true;
> --
> 2.34.1
>

I'd say this counts as 'obvious' ?

Thanks,

Christophe

  reply	other threads:[~2024-04-22 12:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22  9:35 Victor Do Nascimento
2024-04-22 12:26 ` Christophe Lyon [this message]
2024-04-23 12:13 ` Richard Earnshaw (lists)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPS5khYS-Tqrk5c2-UMfLPLpdRBaayLYDRTq=qaOvD0q3axu8A@mail.gmail.com' \
    --to=christophe.lyon@linaro.org \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    --cc=richard.earnshaw@arm.com \
    --cc=victor.donascimento@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).