From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
To: Victor Do Nascimento <victor.donascimento@arm.com>,
binutils@sourceware.org
Cc: nickc@redhat.com
Subject: Re: [PATCH] aarch64: Fix coding style issue in `aarch64-dis.c'
Date: Tue, 23 Apr 2024 13:13:28 +0100 [thread overview]
Message-ID: <e48d6238-542c-4ceb-ad34-ce73c1b27d6b@arm.com> (raw)
In-Reply-To: <20240422093500.46611-1-victor.donascimento@arm.com>
On 22/04/2024 10:35, Victor Do Nascimento wrote:
> Fix integer value being returned from boolean function, as introduced
> in `aarch64: Remove asserts from operand qualifier decoders [PR31595]'.
> ---
> opcodes/aarch64-dis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c
> index b70e6da9eb7..e1c3f557874 100644
> --- a/opcodes/aarch64-dis.c
> +++ b/opcodes/aarch64-dis.c
> @@ -1038,7 +1038,7 @@ aarch64_ext_ft (const aarch64_operand *self ATTRIBUTE_UNUSED,
> return false;
> info->qualifier = get_sreg_qualifier_from_value (value);
> if (info->qualifier == AARCH64_OPND_QLF_ERR)
> - return 0;
> + return false;
> }
>
> return true;
OK, thanks.
R.
prev parent reply other threads:[~2024-04-23 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 9:35 Victor Do Nascimento
2024-04-22 12:26 ` Christophe Lyon
2024-04-23 12:13 ` Richard Earnshaw (lists) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e48d6238-542c-4ceb-ad34-ce73c1b27d6b@arm.com \
--to=richard.earnshaw@arm.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=victor.donascimento@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).